Patchwork [U-Boot] arm/km: use spi claim bus to switch between SPI and NAND

login
register
mail settings
Submitter Holger Brunck
Date June 13, 2012, 1:01 p.m.
Message ID <1339592463-15601-1-git-send-email-holger.brunck@keymile.com>
Download mbox | patch
Permalink /patch/164670/
State Accepted
Headers show

Comments

Holger Brunck - June 13, 2012, 1:01 p.m.
From: Valentin Longchamp <valentin.longchamp@keymile.com>

We overwrite these weak functions from the kirkwood spi code to
use our own method to be able to switch between the SPI NOR and
the NAND flash. This is needed e.g. to update the u-boot. The former
command do_spi_toggle can therefore be removed. And the usage of
this command is removed from the u-boot update command in the
u-boot environment.

Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
cc: Holger Brunck <holger.brunck@keymile.com>
cc: Prafulla Wadaskar <prafulla@marvell.com>
---
Hi Prafulla,
this is now a standalone patch. This patch was already posted, but is now a rebase
of the following three patches from 
http://lists.denx.de/pipermail/u-boot/2012-June/125864.html
[PATCH 01/20] arm/km: enable spi claim bus
[PATCH 02/20] arm/km: use correct kw_gpio function for NAND/SPI switching
[PATCH 18/20] arm/km: implement weak function board_spi_clam_bus/release
[PATCH 19/20] arm/km: remove spi toggle command
This makes the patch much more logical and easier to understand. 

Updates for the remaining patch serie will follow.
Regards

 board/keymile/km_arm/km_arm.c |   44 ++++++----------------------------------
 include/configs/km/km_arm.h   |    9 +++++--
 2 files changed, 13 insertions(+), 40 deletions(-)
Prafulla Wadaskar - July 3, 2012, 7:44 a.m.
> -----Original Message-----
> From: Holger Brunck [mailto:holger.brunck@keymile.com]
> Sent: 13 June 2012 18:31
> To: u-boot@lists.denx.de
> Cc: Valentin Longchamp; Holger Brunck; Prafulla Wadaskar
> Subject: [PATCH] arm/km: use spi claim bus to switch between SPI and
> NAND
> 
> From: Valentin Longchamp <valentin.longchamp@keymile.com>
> 
> We overwrite these weak functions from the kirkwood spi code to
> use our own method to be able to switch between the SPI NOR and
> the NAND flash. This is needed e.g. to update the u-boot. The former
> command do_spi_toggle can therefore be removed. And the usage of
> this command is removed from the u-boot update command in the
> u-boot environment.
> 
> Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com>
> cc: Holger Brunck <holger.brunck@keymile.com>
> cc: Prafulla Wadaskar <prafulla@marvell.com>
> ---
> Hi Prafulla,
> this is now a standalone patch. This patch was already posted, but is
> now a rebase
> of the following three patches from
> http://lists.denx.de/pipermail/u-boot/2012-June/125864.html
> [PATCH 01/20] arm/km: enable spi claim bus
> [PATCH 02/20] arm/km: use correct kw_gpio function for NAND/SPI
> switching
> [PATCH 18/20] arm/km: implement weak function
> board_spi_clam_bus/release
> [PATCH 19/20] arm/km: remove spi toggle command
> This makes the patch much more logical and easier to understand.
> 
> Updates for the remaining patch serie will follow.
> Regards
> 
>  board/keymile/km_arm/km_arm.c |   44 ++++++--------------------------
> --------
>  include/configs/km/km_arm.h   |    9 +++++--
>  2 files changed, 13 insertions(+), 40 deletions(-)

Applied to u-boot-marvell.git master branch by resolving few merge conflicts

Regards...
Prafulla . . .

Patch

diff --git a/board/keymile/km_arm/km_arm.c b/board/keymile/km_arm/km_arm.c
index ed12b5c..cb3402b 100644
--- a/board/keymile/km_arm/km_arm.c
+++ b/board/keymile/km_arm/km_arm.c
@@ -33,6 +33,7 @@ 
 #include <nand.h>
 #include <netdev.h>
 #include <miiphy.h>
+#include <spi.h>
 #include <asm/io.h>
 #include <asm/arch/cpu.h>
 #include <asm/arch/kirkwood.h>
@@ -284,48 +285,17 @@  int board_init(void)
 	return 0;
 }
 
-#if defined(CONFIG_CMD_SF)
-int do_spi_toggle(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
+int board_spi_claim_bus(struct spi_slave *slave)
 {
-	u32 tmp;
-	if (argc < 2)
-		return cmd_usage(cmdtp);
-
-	if ((strcmp(argv[1], "off") == 0)) {
-		printf("SPI FLASH disabled, NAND enabled\n");
-		/* Multi-Purpose Pins Functionality configuration */
-		kwmpp_config[0] = MPP0_NF_IO2;
-		kwmpp_config[1] = MPP1_NF_IO3;
-		kwmpp_config[2] = MPP2_NF_IO4;
-		kwmpp_config[3] = MPP3_NF_IO5;
-
-		kirkwood_mpp_conf(kwmpp_config, NULL);
-		tmp = readl(KW_GPIO0_BASE);
-		writel(tmp | FLASH_GPIO_PIN , KW_GPIO0_BASE);
-	} else if ((strcmp(argv[1], "on") == 0)) {
-		printf("SPI FLASH enabled, NAND disabled\n");
-		/* Multi-Purpose Pins Functionality configuration */
-		kwmpp_config[0] = MPP0_SPI_SCn;
-		kwmpp_config[1] = MPP1_SPI_MOSI;
-		kwmpp_config[2] = MPP2_SPI_SCK;
-		kwmpp_config[3] = MPP3_SPI_MISO;
-
-		kirkwood_mpp_conf(kwmpp_config, NULL);
-		tmp = readl(KW_GPIO0_BASE);
-		writel(tmp & (~FLASH_GPIO_PIN) , KW_GPIO0_BASE);
-	} else {
-		return cmd_usage(cmdtp);
-	}
+	kw_gpio_set_value(KM_FLASH_GPIO_PIN, 0);
 
 	return 0;
 }
 
-U_BOOT_CMD(
-	spitoggle,	2,	0,	do_spi_toggle,
-	"En-/disable SPI FLASH access",
-	"<on|off> - Enable (on) or disable (off) SPI FLASH access\n"
-	);
-#endif
+void board_spi_release_bus(struct spi_slave *slave)
+{
+	kw_gpio_set_value(KM_FLASH_GPIO_PIN, 1);
+}
 
 int dram_init(void)
 {
diff --git a/include/configs/km/km_arm.h b/include/configs/km/km_arm.h
index eb60d29..4626e65 100644
--- a/include/configs/km/km_arm.h
+++ b/include/configs/km/km_arm.h
@@ -227,7 +227,11 @@  int get_scl(void);
 #define CONFIG_SPI_FLASH
 #define CONFIG_SPI_FLASH_STMICRO
 
+/* SPI bus claim MPP configuration */
+#define CONFIG_SYS_KW_SPI_MPP	0x0
+
 #define FLASH_GPIO_PIN			0x00010000
+#define KM_FLASH_GPIO_PIN	16
 
 #define MTDIDS_DEFAULT		"nand0=orion_nand"
 /* test-only: partitioning needs some tuning, this is just for tests */
@@ -237,9 +241,8 @@  int get_scl(void);
 
 #define	CONFIG_KM_UPDATE_UBOOT						\
 	"update="							\
-		"spi on;sf probe 0;sf erase 0 +${filesize};"		\
-		"sf write ${load_addr_r} 0 ${filesize};"		\
-		"spi off\0"
+		"sf probe 0;sf erase 0 +${filesize};"			\
+		"sf write ${load_addr_r} 0 ${filesize};\0"
 
 /*
  * Default environment variables