From patchwork Tue Jun 12 20:50:19 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Beno=C3=AEt_Th=C3=A9baudeau?= X-Patchwork-Id: 164498 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ey0-f184.google.com (mail-ey0-f184.google.com [209.85.215.184]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 97887B6FBC for ; Wed, 13 Jun 2012 06:46:07 +1000 (EST) Received: by eaac11 with SMTP id c11sf2930205eaa.11 for ; Tue, 12 Jun 2012 13:46:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:x-virus-scanned:date:from:to:cc:message-id :subject:mime-version:x-originating-ip:x-mailer:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type :content-transfer-encoding; bh=LLEqx+5Bdt60/MLckbKvPOLY5cPOeNCDu1qQoTM3orI=; b=lSFw7F5/L5tLNFDoUxtHQ0BZ+1j/DxfmCPWVcJV5p+LkrAuaElsbNeB7oTyPOzN7dT HStB4yqaxieqmDgB8VmN/6hBLnxKPpByVmobxuOPmQAWzmLuXUrMhwm7i7iskLTfGGWx 4hvDFDwOiCv0ALQniWE6EpKXDWLztieRPbVr0= Received: by 10.216.141.200 with SMTP id g50mr568090wej.16.1339533963609; Tue, 12 Jun 2012 13:46:03 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.180.99.234 with SMTP id et10ls5573976wib.0.canary; Tue, 12 Jun 2012 13:46:02 -0700 (PDT) Received: by 10.180.19.70 with SMTP id c6mr238828wie.4.1339533962949; Tue, 12 Jun 2012 13:46:02 -0700 (PDT) Received: by 10.180.19.70 with SMTP id c6mr238827wie.4.1339533962935; Tue, 12 Jun 2012 13:46:02 -0700 (PDT) Received: from zose-mta12.web4all.fr (zose-mta12.web4all.fr. [178.33.204.89]) by gmr-mx.google.com with ESMTP id x8si178575wif.3.2012.06.12.13.46.02; Tue, 12 Jun 2012 13:46:02 -0700 (PDT) Received-SPF: pass (google.com: domain of benoit.thebaudeau@advansee.com designates 178.33.204.89 as permitted sender) client-ip=178.33.204.89; Received: from localhost (localhost [127.0.0.1]) by zose-mta12.web4all.fr (Postfix) with ESMTP id 57D6F9087B; Tue, 12 Jun 2012 22:50:28 +0200 (CEST) X-Virus-Scanned: amavisd-new at zose1.web4all.fr Received: from zose-mta12.web4all.fr ([127.0.0.1]) by localhost (zose-mta12.web4all.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S7yG+nL-PMxd; Tue, 12 Jun 2012 22:50:27 +0200 (CEST) Received: from zose-store12.web4all.fr (zose-store-12.w4a.fr [178.33.204.48]) by zose-mta12.web4all.fr (Postfix) with ESMTP id 34B37904F3; Tue, 12 Jun 2012 22:50:27 +0200 (CEST) Date: Tue, 12 Jun 2012 22:50:19 +0200 (CEST) From: =?utf-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?= To: Alessandro Zummo , Sascha Hauer , rtc-linux@googlegroups.com Cc: =?utf-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?= Message-ID: <2125427519.2533544.1339534219329.JavaMail.root@advansee.com> Subject: [rtc-linux] [PATCH] rtc: rtc-mxc: fix irq enabled interrupts warning MIME-Version: 1.0 X-Originating-IP: [88.188.188.98] X-Mailer: Zimbra 7.2.0_GA_2669 (ZimbraWebClient - FF3.0 (Win)/7.2.0_GA_2669) X-Original-Sender: benoit.thebaudeau@advansee.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of benoit.thebaudeau@advansee.com designates 178.33.204.89 as permitted sender) smtp.mail=benoit.thebaudeau@advansee.com Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , [ 29.669224] WARNING: at /linux/kernel/irq/handle.c:146 handle_irq_event_percpu+0x19c/0x1b8() [ 29.669269] irq 25 handler mxc_rtc_interrupt+0x0/0xac enabled interrupts [ 29.669284] Modules linked in: [ 29.669324] [] (unwind_backtrace+0x0/0xf0) from [] (warn_slowpath_common+0x4c/0x64) [ 29.669361] [] (warn_slowpath_common+0x4c/0x64) from [] (warn_slowpath_fmt+0x30/0x40) [ 29.669399] [] (warn_slowpath_fmt+0x30/0x40) from [] (handle_irq_event_percpu+0x19c/0x1b8) [ 29.669439] [] (handle_irq_event_percpu+0x19c/0x1b8) from [] (handle_irq_event+0x28/0x38) [ 29.669479] [] (handle_irq_event+0x28/0x38) from [] (handle_level_irq+0x80/0xc4) [ 29.669517] [] (handle_level_irq+0x80/0xc4) from [] (generic_handle_irq+0x24/0x38) [ 29.669563] [] (generic_handle_irq+0x24/0x38) from [] (handle_IRQ+0x30/0x84) [ 29.669599] [] (handle_IRQ+0x30/0x84) from [] (avic_handle_irq+0x2c/0x4c) [ 29.669633] [] (avic_handle_irq+0x2c/0x4c) from [] (__irq_svc+0x40/0x60) [ 29.669655] Exception stack(0xc050bf60 to 0xc050bfa8) [ 29.669685] bf60: 00000001 00000000 003c4208 c0018e20 c050a000 c050a000 c054a4c8 c050a000 [ 29.669717] bf80: c05157a8 4117b363 80503bb4 00000000 01000000 c050bfa8 c0018e2c c000e808 [ 29.669739] bfa0: 60000013 ffffffff [ 29.669769] [] (__irq_svc+0x40/0x60) from [] (default_idle+0x1c/0x30) [ 29.669805] [] (default_idle+0x1c/0x30) from [] (cpu_idle+0x68/0xa8) [ 29.669846] [] (cpu_idle+0x68/0xa8) from [] (start_kernel+0x22c/0x26c) [ 29.669868] ---[ end trace 2f7406c4b6216986 ]--- Cc: Alessandro Zummo Cc: Sascha Hauer Cc: Benoît Thébaudeau Cc: Signed-off-by: Benoît Thébaudeau Acked-by: Uwe Kleine-König --- .../drivers/rtc/rtc-mxc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git linux-next-HEAD-c90e5d2.orig/drivers/rtc/rtc-mxc.c linux-next-HEAD-c90e5d2/drivers/rtc/rtc-mxc.c index 5e1d64e..e3e50d6 100644 --- linux-next-HEAD-c90e5d2.orig/drivers/rtc/rtc-mxc.c +++ linux-next-HEAD-c90e5d2/drivers/rtc/rtc-mxc.c @@ -202,10 +202,11 @@ static irqreturn_t mxc_rtc_interrupt(int irq, void *dev_id) struct platform_device *pdev = dev_id; struct rtc_plat_data *pdata = platform_get_drvdata(pdev); void __iomem *ioaddr = pdata->ioaddr; + unsigned long flags; u32 status; u32 events = 0; - spin_lock_irq(&pdata->rtc->irq_lock); + spin_lock_irqsave(&pdata->rtc->irq_lock, flags); status = readw(ioaddr + RTC_RTCISR) & readw(ioaddr + RTC_RTCIENR); /* clear interrupt sources */ writew(status, ioaddr + RTC_RTCISR); @@ -224,7 +225,7 @@ static irqreturn_t mxc_rtc_interrupt(int irq, void *dev_id) events |= (RTC_PF | RTC_IRQF); rtc_update_irq(pdata->rtc, 1, events); - spin_unlock_irq(&pdata->rtc->irq_lock); + spin_unlock_irqrestore(&pdata->rtc->irq_lock, flags); return IRQ_HANDLED; }