From patchwork Tue Jun 12 08:58:54 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 164355 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 95417B6FB6 for ; Tue, 12 Jun 2012 19:02:35 +1000 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SeMwI-0003Nm-U3; Tue, 12 Jun 2012 08:59:03 +0000 Received: from mail-ey0-f177.google.com ([209.85.215.177]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1SeMwF-0003MP-FN for linux-arm-kernel@lists.infradead.org; Tue, 12 Jun 2012 08:59:00 +0000 Received: by eaaf11 with SMTP id f11so2449353eaa.36 for ; Tue, 12 Jun 2012 01:58:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding :x-gm-message-state; bh=emgwcW1FC2jSjLI25BtNy3KGn8p9pR6zURnzrDIFAQw=; b=A/Yl5uaK8mcE7Tllg40k5H70tvP07v6rydtnhiyJEP9IdFkngXx8r4/L7GJztl1/Xr /TnjGCNSlEx5PkmoYv9ffB37sTMxZPTdZSKymCGLbpCb+lHF5r7r9zJkPT8NPL8DnEqa B1/ycFiBjV15agbYE1Fq/hCMeBtOGBQ8qArJZG5F2JYPX2Fm57YZ072mrNy+2+yTutfF xVo5IJX5MAd1gPm6/eoujMSQJ+4EjGoeVuU66JusM4aLWp/HXWeOeU2KMmGedRtLnTUB YV0fPalGGbhxz7KzkYQ2ex/6LHSOiOMBf+sJ//GgQd125aTLn+fltUGlcu5BXVIwSouQ Ds4g== Received: by 10.14.127.8 with SMTP id c8mr6817173eei.148.1339491537740; Tue, 12 Jun 2012 01:58:57 -0700 (PDT) Received: from [192.168.0.133] (cpc1-aztw13-0-0-cust473.18-1.cable.virginmedia.com. [77.102.241.218]) by mx.google.com with ESMTPS id y54sm61808605eef.10.2012.06.12.01.58.55 (version=SSLv3 cipher=OTHER); Tue, 12 Jun 2012 01:58:56 -0700 (PDT) Message-ID: <4FD704CE.5010300@linaro.org> Date: Tue, 12 Jun 2012 09:58:54 +0100 From: Lee Jones User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120410 Thunderbird/11.0.1 MIME-Version: 1.0 To: Lee Jones Subject: Re: [PATCH 03/14] mfd: ab8500-gpadc: Enable IRQF_ONESHOT when requesting a threaded IRQ References: <1339428307-3850-1-git-send-email-lee.jones@linaro.org> <1339428307-3850-4-git-send-email-lee.jones@linaro.org> In-Reply-To: <1339428307-3850-4-git-send-email-lee.jones@linaro.org> X-Gm-Message-State: ALoCoQkxHn78fgIgME+gudjy1J5WqiSv0fB3IQqf/PTBRdcvlOAAGm/98WbqiZ279Ou9WGzdzRk/ X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.215.177 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Samuel Ortiz , arnd@arndb.de, linux-kernel@vger.kernel.org, stable@vger.kernel.org, grant.likely@secretlab.ca, linux-arm-kernel@lists.infradead.org, linus.walleij@stericsson.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org Lee Jones Linaro ST-Ericsson Landing Team Lead M: +44 77 88 633 515 Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From: Lee Jones Date: Tue, 22 May 2012 15:13:13 +0100 Subject: [PATCH 03/14] mfd: ab8500-gpadc: Enable IRQF_ONESHOT when requesting a threaded IRQ The kernel now forces IRQs to be ONESHOT if no IRQ handler is passed. Cc: Samuel Ortiz Cc: stable@vger.kernel.org Acked-by: Linus Walleij Signed-off-by: Lee Jones --- drivers/mfd/ab8500-gpadc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c index b86fd8e..b6cbc3ba 100644 --- a/drivers/mfd/ab8500-gpadc.c +++ b/drivers/mfd/ab8500-gpadc.c @@ -599,7 +599,8 @@ static int __devinit ab8500_gpadc_probe(struct platform_device *pdev) /* Register interrupt - SwAdcComplete */ ret = request_threaded_irq(gpadc->irq, NULL, ab8500_bm_gpswadcconvend_handler, - IRQF_NO_SUSPEND | IRQF_SHARED, "ab8500-gpadc", gpadc); + IRQF_ONESHOT | IRQF_NO_SUSPEND | IRQF_SHARED, + "ab8500-gpadc", gpadc); if (ret < 0) { dev_err(gpadc->dev, "Failed to register interrupt, irq: %d\n", gpadc->irq);