From patchwork Tue Jun 12 07:51:05 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gerd Hoffmann X-Patchwork-Id: 164338 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 7F24BB6FBD for ; Tue, 12 Jun 2012 17:51:51 +1000 (EST) Received: from localhost ([::1]:52783 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SeLtF-0007vg-Ch for incoming@patchwork.ozlabs.org; Tue, 12 Jun 2012 03:51:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SeLsq-0007X8-Lh for qemu-devel@nongnu.org; Tue, 12 Jun 2012 03:51:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SeLsk-0001YX-Lt for qemu-devel@nongnu.org; Tue, 12 Jun 2012 03:51:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30119) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SeLsk-0001X7-Cs for qemu-devel@nongnu.org; Tue, 12 Jun 2012 03:51:18 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5C7pGG4024221 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 12 Jun 2012 03:51:16 -0400 Received: from rincewind.home.kraxel.org (ovpn-116-37.ams2.redhat.com [10.36.116.37]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q5C7pFiW018262; Tue, 12 Jun 2012 03:51:15 -0400 Received: by rincewind.home.kraxel.org (Postfix, from userid 500) id 6ADB740C41; Tue, 12 Jun 2012 09:51:14 +0200 (CEST) From: Gerd Hoffmann To: qemu-devel@nongnu.org Date: Tue, 12 Jun 2012 09:51:05 +0200 Message-Id: <1339487474-8481-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1339487474-8481-1-git-send-email-kraxel@redhat.com> References: <1339487474-8481-1-git-send-email-kraxel@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: Alon Levy , Gerd Hoffmann Subject: [Qemu-devel] [PATCH 01/10] ui/spice-display.c: add missing initialization for valgrind X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Alon Levy We can't initialize QXLDevSurfaceCreate field by field because it has a pa hole, and so 4 bytes remain uninitialized when building on x86-64, so just memset. Signed-off-by: Alon Levy Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/ui/spice-display.c b/ui/spice-display.c index 5418eb3..3e8f0b3 100644 --- a/ui/spice-display.c +++ b/ui/spice-display.c @@ -244,6 +244,8 @@ void qemu_spice_create_host_primary(SimpleSpiceDisplay *ssd) { QXLDevSurfaceCreate surface; + memset(&surface, 0, sizeof(surface)); + dprint(1, "%s: %dx%d\n", __FUNCTION__, ds_get_width(ssd->ds), ds_get_height(ssd->ds));