From patchwork Mon Jun 11 23:04:48 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 164277 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 4601EB6FC4 for ; Tue, 12 Jun 2012 09:05:26 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1340060727; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Mailing-List:Precedence: List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=3g8eH/1jsfYUVsJ0YRLSnw7rCx8=; b=PdKpcispwedR2CF dHQ9oafgKjn5iCAgqpQB0bmXOqvjU4adOt5mZftn7zk9haTRsEEdlhnONC1YseHb hb4RCz3SnqHlg5gEZeQj9nOaRAw/3Ymi+LMDG6PGwjcVZHgckNVCD3ObNL4VY0Il NGkpFVyphWdR7bQSgKbW0wKBTsqs= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=sVeTnMHinlL8efAoTUgDU4Jj9Fj/L3Hwwvf7qVQy9yVzehxbTMRlLEdq3m6KpG zHYtptmn9TuioXu6lhbeat5p62m+z/PUFU55CMxWywkvVsNyvETZRZ1gfe3SbGkK V5cs4bogS7rr3QYI9KMceO15LBqAgSEMpvLTuLBiwODDo=; Received: (qmail 21369 invoked by alias); 11 Jun 2012 23:05:19 -0000 Received: (qmail 21357 invoked by uid 22791); 11 Jun 2012 23:05:18 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_THREADED, RCVD_IN_DNSWL_HI, RCVD_IN_HOSTKARMA_W, SPF_HELO_PASS, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Jun 2012 23:04:59 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5BN4qQ3006739 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 11 Jun 2012 19:04:52 -0400 Received: from pebble.twiddle.home (vpn-10-127.rdu.redhat.com [10.11.10.127]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q5BN4pE6015928; Mon, 11 Jun 2012 19:04:51 -0400 Message-ID: <4FD67990.1080904@redhat.com> Date: Mon, 11 Jun 2012 16:04:48 -0700 From: Richard Henderson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Jay K CC: GCC Patches Subject: Re: constant that doesn't fit in 32bits in alpha.c References: In-Reply-To: X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 2012-06-10 02:18, Jay K wrote: > > gcc-4.7.0/gcc/config/alpha/alpha.c > > > word1 = expand_and (DImode, word1, GEN_INT (0xffff0fff0000fff0), NULL); > > > That "big" constant isn't portable since it doesn't fit in 32bits. > > > 1) append LL > or 2) break it up into an expression, like > ((HOST_WIDE_INT)0xffff0fff) << 8) | 0x0fff0 > > > or such. Addressed like so. I couldn't think of any nice way to define this such that it could be generic, so I left it local to this bit o code. r~ * lib/target-supports.exp (check_effective_target_sync_long_long_runtime): Use check_effective_target_lp64 instead of check_effective_target_powerpc64 for powerpc targets. diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp index 568f6b1..c937484 100644 --- a/gcc/testsuite/lib/target-supports.exp +++ b/gcc/testsuite/lib/target-supports.exp @@ -3796,7 +3796,7 @@ proc check_effective_target_sync_long_long_runtime { } { && [check_effective_target_lp64] && [check_effective_target_ultrasparc_hw]) } { return 1 - } elseif { [check_effective_target_powerpc64] } { + } elseif { [istarget powerpc*-*-*] && [check_effective_target_lp64] } { return 1 } else { return 0