Patchwork [01/14] rtc: ab8500-rtc: IRQF_ONESHOT when requesting a threaded IRQ

login
register
mail settings
Submitter Lee Jones
Date June 11, 2012, 3:24 p.m.
Message ID <1339428307-3850-2-git-send-email-lee.jones@linaro.org>
Download mbox | patch
Permalink /patch/164216/
State New
Headers show

Comments

Lee Jones - June 11, 2012, 3:24 p.m.
The kernel now forces IRQs to be ONESHOT if no IRQ handler is passed.

Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: rtc-linux@googlegroups.com
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/rtc/rtc-ab8500.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Arnd Bergmann - June 11, 2012, 3:31 p.m.
On Monday 11 June 2012, Lee Jones wrote:
> The kernel now forces IRQs to be ONESHOT if no IRQ handler is passed.
> 
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: rtc-linux@googlegroups.com
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Isn't this a bug fix that should be applied to the stable kernels too?

	Arnd
Lee Jones - June 11, 2012, 3:37 p.m.
On 11/06/12 16:31, Arnd Bergmann wrote:
> On Monday 11 June 2012, Lee Jones wrote:
>> The kernel now forces IRQs to be ONESHOT if no IRQ handler is passed.
>>
>> Cc: Alessandro Zummo<a.zummo@towertech.it>
>> Cc: rtc-linux@googlegroups.com
>> Signed-off-by: Lee Jones<lee.jones@linaro.org>
>
> Isn't this a bug fix that should be applied to the stable kernels too?

Possibly. Should we alert Greg (CC'ed - alerted)?
Greg KH - June 11, 2012, 3:51 p.m.
On Mon, Jun 11, 2012 at 04:37:18PM +0100, Lee Jones wrote:
> On 11/06/12 16:31, Arnd Bergmann wrote:
> >On Monday 11 June 2012, Lee Jones wrote:
> >>The kernel now forces IRQs to be ONESHOT if no IRQ handler is passed.
> >>
> >>Cc: Alessandro Zummo<a.zummo@towertech.it>
> >>Cc: rtc-linux@googlegroups.com
> >>Signed-off-by: Lee Jones<lee.jones@linaro.org>
> >
> >Isn't this a bug fix that should be applied to the stable kernels too?
> 
> Possibly. Should we alert Greg (CC'ed - alerted)?

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>
Lee Jones - June 11, 2012, 4:01 p.m.
On 11/06/12 16:51, Greg Kroah-Hartman wrote:
> On Mon, Jun 11, 2012 at 04:37:18PM +0100, Lee Jones wrote:
>> On 11/06/12 16:31, Arnd Bergmann wrote:
>>> On Monday 11 June 2012, Lee Jones wrote:
>>>> The kernel now forces IRQs to be ONESHOT if no IRQ handler is passed.
>>>>
>>>> Cc: Alessandro Zummo<a.zummo@towertech.it>
>>>> Cc: rtc-linux@googlegroups.com
>>>> Signed-off-by: Lee Jones<lee.jones@linaro.org>
>>>
>>> Isn't this a bug fix that should be applied to the stable kernels too?
>>
>> Possibly. Should we alert Greg (CC'ed - alerted)?
> 
> <formletter>
> 
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.
> 
> </formletter>

I wasn't submitting, merely asking if it would be suitable for inclusion. :)

If it is, I'd be happy to _properly_ submit this and its ab8500-gpadc counterpart.
Linus Walleij - June 11, 2012, 8:54 p.m.
On Mon, Jun 11, 2012 at 6:01 PM, Lee Jones <lee.jones@linaro.org> wrote:

> I wasn't submitting, merely asking if it would be suitable for inclusion. :)

It is.

> If it is, I'd be happy to _properly_ submit this and its ab8500-gpadc counterpart.

Please do.
Acked-by: Linus Walleij <linus.walleij@linaro.org>

Thanks,
Linus Walleij

Patch

diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c
index 4bcf9ca..b11a2ec 100644
--- a/drivers/rtc/rtc-ab8500.c
+++ b/drivers/rtc/rtc-ab8500.c
@@ -422,7 +422,7 @@  static int __devinit ab8500_rtc_probe(struct platform_device *pdev)
 	}
 
 	err = request_threaded_irq(irq, NULL, rtc_alarm_handler,
-		IRQF_NO_SUSPEND, "ab8500-rtc", rtc);
+		IRQF_NO_SUSPEND | IRQF_ONESHOT, "ab8500-rtc", rtc);
 	if (err < 0) {
 		rtc_device_unregister(rtc);
 		return err;