Patchwork Makefile.user: Define CONFIG_USER_ONLY for libuser/

login
register
mail settings
Submitter Andreas Färber
Date June 9, 2012, 11:56 a.m.
Message ID <1339243002-13760-1-git-send-email-afaerber@suse.de>
Download mbox | patch
Permalink /patch/163913/
State New
Headers show

Comments

Andreas Färber - June 9, 2012, 11:56 a.m.
In *-*-user/ build dirs CONFIG_USER_ONLY is defined via config-target.h.
In libuser/ it is not defined.

Add it via QEMU_CFLAGS.

Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 Soon needed for cpu.c.

 Makefile.user |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Paolo Bonzini - June 11, 2012, 5:51 a.m.
----- Messaggio originale -----
> Da: "Andreas Färber" <afaerber@suse.de>
> A: qemu-devel@nongnu.org
> Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, "Andreas Färber" <afaerber@suse.de>
> Inviato: Sabato, 9 giugno 2012 13:56:42
> Oggetto: [PATCH] Makefile.user: Define CONFIG_USER_ONLY for libuser/
> 
> In *-*-user/ build dirs CONFIG_USER_ONLY is defined via
> config-target.h.
> In libuser/ it is not defined.
> 
> Add it via QEMU_CFLAGS.
> 
> Signed-off-by: Andreas Färber <afaerber@suse.de>

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo

> ---
>  Soon needed for cpu.c.
> 
>  Makefile.user |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile.user b/Makefile.user
> index b717820..ab70eb3 100644
> --- a/Makefile.user
> +++ b/Makefile.user
> @@ -10,6 +10,7 @@ $(call set-vpath, $(SRC_PATH))
>  
>  QEMU_CFLAGS+=-I..
>  QEMU_CFLAGS += -I$(SRC_PATH)/include
> +QEMU_CFLAGS += -DCONFIG_USER_ONLY
>  
>  include $(SRC_PATH)/Makefile.objs
>  
> --
> 1.7.7
> 
>
Stefan Hajnoczi - June 12, 2012, 9:50 a.m.
On Sat, Jun 09, 2012 at 01:56:42PM +0200, Andreas Färber wrote:
> In *-*-user/ build dirs CONFIG_USER_ONLY is defined via config-target.h.
> In libuser/ it is not defined.
> 
> Add it via QEMU_CFLAGS.
> 
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  Soon needed for cpu.c.
> 
>  Makefile.user |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan

Patch

diff --git a/Makefile.user b/Makefile.user
index b717820..ab70eb3 100644
--- a/Makefile.user
+++ b/Makefile.user
@@ -10,6 +10,7 @@  $(call set-vpath, $(SRC_PATH))
 
 QEMU_CFLAGS+=-I..
 QEMU_CFLAGS += -I$(SRC_PATH)/include
+QEMU_CFLAGS += -DCONFIG_USER_ONLY
 
 include $(SRC_PATH)/Makefile.objs