From patchwork Sat Jun 9 07:08:38 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Weil X-Patchwork-Id: 163889 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 44E06B6FCC for ; Sat, 9 Jun 2012 17:08:56 +1000 (EST) Received: from localhost ([::1]:58559 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SdFn2-0005TL-8S for incoming@patchwork.ozlabs.org; Sat, 09 Jun 2012 03:08:52 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SdFmu-0005Sn-Gk for qemu-devel@nongnu.org; Sat, 09 Jun 2012 03:08:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SdFms-0005wM-Ph for qemu-devel@nongnu.org; Sat, 09 Jun 2012 03:08:44 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:46170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SdFms-0005w6-Jq; Sat, 09 Jun 2012 03:08:42 -0400 Received: from localhost (v220110690675601.yourvserver.net.local [127.0.0.1]) by v220110690675601.yourvserver.net (Postfix) with ESMTP id 615177280025; Sat, 9 Jun 2012 09:08:40 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at weilnetz.de Received: from v220110690675601.yourvserver.net ([127.0.0.1]) by localhost (v220110690675601.yourvserver.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wMb0SJj1TYpi; Sat, 9 Jun 2012 09:08:39 +0200 (CEST) Received: by v220110690675601.yourvserver.net (Postfix, from userid 1000) id EBA067280026; Sat, 9 Jun 2012 09:08:39 +0200 (CEST) From: Stefan Weil To: qemu-trivial Date: Sat, 9 Jun 2012 09:08:38 +0200 Message-Id: <1339225719-5434-1-git-send-email-sw@weilnetz.de> X-Mailer: git-send-email 1.7.10 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 78.47.199.172 Cc: Stefan Weil , qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH 1/2] Makefile: Remove BUILD_DIR from qapi-dir X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org qapi-dir does not need an absolute path. All other build directories are relative. When BUILD_DIR is removed, the build output looks better (no long lines with absolute paths when everything else uses short lines): GEN qapi-generated/qga-qapi-types.c CC qapi-generated/qga-qapi-types.o GEN qapi-generated/qga-qapi-visit.c CC qapi-generated/qga-qapi-visit.o GEN qapi-generated/qga-qmp-marshal.c CC qapi-generated/qga-qmp-marshal.o Using a relative path also avoids potential problems when BUILD_DIR includes blanks. Signed-off-by: Stefan Weil --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 32550cb..8880a3e 100644 --- a/Makefile +++ b/Makefile @@ -171,7 +171,7 @@ fsdev/virtfs-proxy-helper$(EXESUF): LIBS += -lcap qemu-img-cmds.h: $(SRC_PATH)/qemu-img-cmds.hx $(call quiet-command,sh $(SRC_PATH)/scripts/hxtool -h < $< > $@," GEN $@") -qapi-dir := $(BUILD_DIR)/qapi-generated +qapi-dir := qapi-generated qemu-ga$(EXESUF): LIBS = $(LIBS_QGA) qemu-ga$(EXESUF): QEMU_CFLAGS += -I $(qapi-dir)