Patchwork dump: Fix build breakage (missing sys/procfs.h)

login
register
mail settings
Submitter Stefan Weil
Date June 8, 2012, 5:57 p.m.
Message ID <1339178245-29001-1-git-send-email-sw@weilnetz.de>
Download mbox | patch
Permalink /patch/163838/
State Accepted
Headers show

Comments

Stefan Weil - June 8, 2012, 5:57 p.m.
sys/procfs is not available everywhere (MingW does not have it).

Remove this and more unused or redundant include statements.
This fixes the broken build.

qerror.h was previously included indirectly.
Add an explicit include statement for it because it is needed.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 dump-stub.c |   15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)
Blue Swirl - June 9, 2012, 11:28 a.m.
Thanks, applied.

On Fri, Jun 8, 2012 at 5:57 PM, Stefan Weil <sw@weilnetz.de> wrote:
> sys/procfs is not available everywhere (MingW does not have it).
>
> Remove this and more unused or redundant include statements.
> This fixes the broken build.
>
> qerror.h was previously included indirectly.
> Add an explicit include statement for it because it is needed.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  dump-stub.c |   15 +--------------
>  1 file changed, 1 insertion(+), 14 deletions(-)
>
> diff --git a/dump-stub.c b/dump-stub.c
> index 4c8bedb..165c005 100644
> --- a/dump-stub.c
> +++ b/dump-stub.c
> @@ -12,22 +12,9 @@
>  */
>
>  #include "qemu-common.h"
> -#include <unistd.h>
> -#include "elf.h"
> -#include <sys/procfs.h>
> -#include <glib.h>
> -#include "cpu.h"
> -#include "cpu-all.h"
> -#include "targphys.h"
> -#include "monitor.h"
> -#include "kvm.h"
>  #include "dump.h"
> -#include "sysemu.h"
> -#include "bswap.h"
> -#include "memory_mapping.h"
> -#include "error.h"
> +#include "qerror.h"
>  #include "qmp-commands.h"
> -#include "gdbstub.h"
>
>  /* we need this function in hmp.c */
>  void qmp_dump_guest_memory(bool paging, const char *file, bool has_begin,
> --
> 1.7.10
>
>

Patch

diff --git a/dump-stub.c b/dump-stub.c
index 4c8bedb..165c005 100644
--- a/dump-stub.c
+++ b/dump-stub.c
@@ -12,22 +12,9 @@ 
  */
 
 #include "qemu-common.h"
-#include <unistd.h>
-#include "elf.h"
-#include <sys/procfs.h>
-#include <glib.h>
-#include "cpu.h"
-#include "cpu-all.h"
-#include "targphys.h"
-#include "monitor.h"
-#include "kvm.h"
 #include "dump.h"
-#include "sysemu.h"
-#include "bswap.h"
-#include "memory_mapping.h"
-#include "error.h"
+#include "qerror.h"
 #include "qmp-commands.h"
-#include "gdbstub.h"
 
 /* we need this function in hmp.c */
 void qmp_dump_guest_memory(bool paging, const char *file, bool has_begin,