From patchwork Fri Jun 8 01:08:02 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: MIPS/GDB: Correct stub handling of CP1 FIR X-Patchwork-Submitter: "Maciej W. Rozycki" X-Patchwork-Id: 163704 Message-Id: To: Cc: "Maciej W. Rozycki" , Aurelien Jarno Date: Fri, 8 Jun 2012 02:08:02 +0100 From: "Maciej W. Rozycki" List-Id: The CP1 FIR register is read-only, ignore any write attempts from the GDB stub. Signed-off-by: Maciej W. Rozycki Reviewed-by: Richard Henderson --- Definitely obvious, please apply. Maciej qemu-mips-fir.diff Index: qemu-git-trunk/gdbstub.c =================================================================== --- qemu-git-trunk.orig/gdbstub.c 2012-06-08 01:11:04.000000000 +0100 +++ qemu-git-trunk/gdbstub.c 2012-06-08 01:42:22.865584444 +0100 @@ -1130,7 +1130,9 @@ static int cpu_gdb_write_register(CPUMIP /* set rounding mode */ RESTORE_ROUNDING_MODE; break; - case 71: env->active_fpu.fcr0 = tmp; break; + case 71: + /* FIR is read-only. Ignore writes. */ + break; } return sizeof(target_ulong); }