Patchwork genhooks: always bail out if tm.texi lacks place for hook

login
register
mail settings
Submitter Andreas Schwab
Date June 7, 2012, 12:12 p.m.
Message ID <m2ipf3wcbe.fsf_-_@igel.home>
Download mbox | patch
Permalink /patch/163628/
State New
Headers show

Comments

Andreas Schwab - June 7, 2012, 12:12 p.m.
So that it doesn't happen again.  Committed as obvious.

Andreas.

	* genhooks.c (main): Set progname.
	(emit_documentation): Remove variable found_start, always bail out
	when a place is missing.
	* doc/tm.texi.in (C++ ABI): Add @hook
	TARGET_CXX_DECL_MANGLING_CONTEXT.

Patch

diff --git a/gcc/doc/tm.texi.in b/gcc/doc/tm.texi.in
index 31dedad..79b9e6e 100644
--- a/gcc/doc/tm.texi.in
+++ b/gcc/doc/tm.texi.in
@@ -10077,6 +10077,8 @@  unloaded. The default is to return false.
 
 @hook TARGET_CXX_ADJUST_CLASS_AT_DEFINITION
 
+@hook TARGET_CXX_DECL_MANGLING_CONTEXT
+
 @node Named Address Spaces
 @section Adding support for named address spaces
 @cindex named address spaces
diff --git a/gcc/genhooks.c b/gcc/genhooks.c
index fc48e45..19bfb5a 100644
--- a/gcc/genhooks.c
+++ b/gcc/genhooks.c
@@ -1,6 +1,6 @@ 
 /* Process target.def to create initialization macros definition in
    target-hooks-def.h and documentation in target-hooks.texi.
-   Copyright (C) 2009, 2010, 2011 Free Software Foundation, Inc.
+   Copyright (C) 2009, 2010, 2011, 2012 Free Software Foundation, Inc.
 
 This file is part of GCC.
 
@@ -120,7 +120,6 @@  emit_documentation (const char *in_fname)
   char buf[1000];
   htab_t start_hooks = htab_create (99, s_hook_hash, s_hook_eq_p, (htab_del) 0);
   FILE *f;
-  bool found_start = false;
 
   /* Enter all the start hooks in start_hooks.  */
   f = fopen (in_fname, "r");
@@ -164,9 +163,8 @@  emit_documentation (const char *in_fname)
 	  if (shp->pos >= 0)
 	    fatal ("Duplicate hook %s\n", sh.name);
 	  shp->pos = i;
-	  found_start = true;
 	}
-      else if (!found_start)
+      else
 	fatal ("No place specified to document hook %s\n", sh.name);
       free (sh.name);
     }
@@ -341,6 +339,8 @@  emit_init_macros (const char *docname)
 int
 main (int argc, char **argv)
 {
+  progname = "genhooks";
+
   if (argc >= 3)
     emit_documentation (argv[2]);
   else