Patchwork synergy: Remove -Werror from CXXFLAGS

login
register
mail settings
Submitter Markos Chandras
Date June 7, 2012, 9:58 a.m.
Message ID <1339063094-25298-1-git-send-email-markos.chandras@imgtec.com>
Download mbox | patch
Permalink /patch/163562/
State Superseded
Headers show

Comments

Markos Chandras - June 7, 2012, 9:58 a.m.
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
 package/synergy/synergy-1.3.1-remove-werror.patch |   29 +++++++++++++++++++++
 1 files changed, 29 insertions(+), 0 deletions(-)
 create mode 100644 package/synergy/synergy-1.3.1-remove-werror.patch
Peter Korsgaard - June 11, 2012, 7:02 a.m.
>>>>> "Markos" == Markos Chandras <markos.chandras@imgtec.com> writes:

 Markos> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
 Markos> ---
 Markos>  package/synergy/synergy-1.3.1-remove-werror.patch |   29 +++++++++++++++++++++
 Markos>  1 files changed, 29 insertions(+), 0 deletions(-)
 Markos>  create mode 100644 package/synergy/synergy-1.3.1-remove-werror.patch

 Markos> diff --git a/package/synergy/synergy-1.3.1-remove-werror.patch b/package/synergy/synergy-1.3.1-remove-werror.patch
 Markos> new file mode 100644
 Markos> index 0000000..fe55778
 Markos> --- /dev/null
 Markos> +++ b/package/synergy/synergy-1.3.1-remove-werror.patch
 Markos> @@ -0,0 +1,29 @@
 Markos> +Remove -Werror from CXXFLAGS
 Markos> +
 Markos> +Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
 Markos> +
 Markos> +Index: synergy-1.3.1/configure
 Markos> +===================================================================
 Markos> +--- synergy-1.3.1.orig/configure
 Markos> ++++ synergy-1.3.1/configure

Please patch configure.ac (and ass SYNERGY_AUTORECONF = YES in
synergy.mk) instead of the generated configure script.

Out of interest, on what configs do you see warnings? I haven't noticed
any build errors on the autobuilder.
Markos Chandras - June 11, 2012, 8:08 a.m.
On 06/11/2012 08:02 AM, Peter Korsgaard wrote:

>>>>>> "Markos" == Markos Chandras <markos.chandras@imgtec.com> writes:
> 
>  Markos> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>  Markos> ---
>  Markos>  package/synergy/synergy-1.3.1-remove-werror.patch |   29 +++++++++++++++++++++
>  Markos>  1 files changed, 29 insertions(+), 0 deletions(-)
>  Markos>  create mode 100644 package/synergy/synergy-1.3.1-remove-werror.patch
> 
>  Markos> diff --git a/package/synergy/synergy-1.3.1-remove-werror.patch b/package/synergy/synergy-1.3.1-remove-werror.patch
>  Markos> new file mode 100644
>  Markos> index 0000000..fe55778
>  Markos> --- /dev/null
>  Markos> +++ b/package/synergy/synergy-1.3.1-remove-werror.patch
>  Markos> @@ -0,0 +1,29 @@
>  Markos> +Remove -Werror from CXXFLAGS
>  Markos> +
>  Markos> +Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>  Markos> +
>  Markos> +Index: synergy-1.3.1/configure
>  Markos> +===================================================================
>  Markos> +--- synergy-1.3.1.orig/configure
>  Markos> ++++ synergy-1.3.1/configure
> 
> Please patch configure.ac (and ass SYNERGY_AUTORECONF = YES in
> synergy.mk) instead of the generated configure script.
> 
> Out of interest, on what configs do you see warnings? I haven't noticed
> any build errors on the autobuilder.
> 

Hi Peter,

There is no configure.ac in the sources and this is why I patched the
generated configure file.

As for the errors, I guess it depends on the toolchain and gcc version
that is being used. I am seeing something like this:

cc1plus: warnings being treated as errors
CTCPSocket.cpp: In member function 'virtual void CTCPSocket::write(const
void*, UInt32)':
CTCPSocket.cpp:143: warning: 'wasEmpty' may be used uninitialized in
this function
Peter Korsgaard - June 11, 2012, 8:50 a.m.
>>>>> "Markos" == Markos Chandras <Markos.Chandras@imgtec.com> writes:

Hi,

 Markos> There is no configure.ac in the sources and this is why I patched the
 Markos> generated configure file.

True, but there's configure.in (the old name for configure.ac).

 Markos> As for the errors, I guess it depends on the toolchain and gcc
 Markos> version that is being used. I am seeing something like this:

 Markos> cc1plus: warnings being treated as errors CTCPSocket.cpp: In
 Markos> member function 'virtual void CTCPSocket::write(const void*,
 Markos> UInt32)': CTCPSocket.cpp:143: warning: 'wasEmpty' may be used
 Markos> uninitialized in this function

Ok, thanks.
Thomas Petazzoni - June 11, 2012, 8:52 a.m.
Le Mon, 11 Jun 2012 09:08:04 +0100,
Markos Chandras <Markos.Chandras@imgtec.com> a écrit :

> There is no configure.ac in the sources and this is why I patched the
> generated configure file.

The file is named configure.in. This is the one that should be
modified, and the package marked SYNERGY_AUTORECONF = YES. The
configure shell script is generated by autoconf from configure.in (or
sometimes configure.ac), and therefore should preferably not be
modified directly.

> As for the errors, I guess it depends on the toolchain and gcc version
> that is being used. I am seeing something like this:

And precisely which toolchain and gcc version are you using? If it
appears that it generates some errors we haven't seen, then we might
include it in our automated build tests, to extend their coverage.

Regards,

Thomas
Markos Chandras - June 11, 2012, 8:53 a.m.
On 06/11/2012 09:50 AM, Peter Korsgaard wrote:

>>>>>> "Markos" == Markos Chandras <Markos.Chandras@imgtec.com> writes:
> 
> Hi,
> 
>  Markos> There is no configure.ac in the sources and this is why I patched the
>  Markos> generated configure file.
> 
> True, but there's configure.in (the old name for configure.ac).
> 


Hi Peter,

Ok I will prepare a new patch

Patch

diff --git a/package/synergy/synergy-1.3.1-remove-werror.patch b/package/synergy/synergy-1.3.1-remove-werror.patch
new file mode 100644
index 0000000..fe55778
--- /dev/null
+++ b/package/synergy/synergy-1.3.1-remove-werror.patch
@@ -0,0 +1,29 @@ 
+Remove -Werror from CXXFLAGS
+
+Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
+
+Index: synergy-1.3.1/configure
+===================================================================
+--- synergy-1.3.1.orig/configure
++++ synergy-1.3.1/configure
+@@ -10835,20 +10835,6 @@ echo $ECHO_N "checking for C++ compiler 
+ echo "${ECHO_T}$acx_cxx_warnings" >&6
+ 
+ 
+-	echo "$as_me:$LINENO: checking for C++ compiler warning are errors flags" >&5
+-echo $ECHO_N "checking for C++ compiler warning are errors flags... $ECHO_C" >&6
+-	if test "$GXX" = "yes"; then
+-		acx_cxx_warnings_are_errors="-Werror"
+-	fi
+-	if test -n "$acx_cxx_warnings_are_errors"; then
+-		CXXFLAGS="$CXXFLAGS $acx_cxx_warnings_are_errors"
+-	else
+-		acx_cxx_warnings_are_errors="unknown"
+-	fi
+-	echo "$as_me:$LINENO: result: $acx_cxx_warnings_are_errors" >&5
+-echo "${ECHO_T}$acx_cxx_warnings_are_errors" >&6
+-
+-
+ CXXFLAGS="$CXXFLAGS $SYNERGY_CXXFLAGS $ARCH_CFLAGS"
+ OBJCXXFLAGS="$OBJCXXFLAGS $CXXFLAGS $ARCH_CFLAGS"
+ LIBS="$NANOSLEEP_LIBS $INET_ATON_LIBS $ARCH_LIBS $LIBS"