| Message ID | 20120606184559.GA27763@redhat.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Dave Jones <davej@redhat.com> Date: Wed, 6 Jun 2012 14:45:59 -0400 > I accidentally triggered this printk, which amused me for a few moments. > Given we're post 2.2, we could just -EACCES, but does anyone even care about Appletalk now ? > I figure it's better to leave sleeping dogs lie, and just update the message. > > Signed-off-by: Dave Jones <davej@redhat.com> Applied, but I made a few refinements. I made it use pr_warn() and also prefixed the message with "atalk_connect: " so if someone sees this it's easier to figure out where it's coming from. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c index 0301b32..12e9100 100644 --- a/net/appletalk/ddp.c +++ b/net/appletalk/ddp.c @@ -1208,9 +1208,7 @@ static int atalk_connect(struct socket *sock, struct sockaddr *uaddr, if (addr->sat_addr.s_node == ATADDR_BCAST && !sock_flag(sk, SOCK_BROADCAST)) { #if 1 - printk(KERN_WARNING "%s is broken and did not set " - "SO_BROADCAST. It will break when 2.2 is " - "released.\n", + printk(KERN_WARNING "%s is broken and did not set SO_BROADCAST.\n", current->comm); #else return -EACCES;
I accidentally triggered this printk, which amused me for a few moments. Given we're post 2.2, we could just -EACCES, but does anyone even care about Appletalk now ? I figure it's better to leave sleeping dogs lie, and just update the message. Signed-off-by: Dave Jones <davej@redhat.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html