From patchwork Tue Jun 5 22:04:50 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 163182 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 06D0EB6F86 for ; Wed, 6 Jun 2012 08:05:36 +1000 (EST) Received: from localhost ([::1]:55678 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sc1sb-0004XO-PJ for incoming@patchwork.ozlabs.org; Tue, 05 Jun 2012 18:05:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sc1sI-0004M2-Ej for qemu-devel@nongnu.org; Tue, 05 Jun 2012 18:05:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sc1sG-00014u-NZ for qemu-devel@nongnu.org; Tue, 05 Jun 2012 18:05:14 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:32775) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sc1sG-00014S-Fe for qemu-devel@nongnu.org; Tue, 05 Jun 2012 18:05:12 -0400 Received: by dadv2 with SMTP id v2so8527920dad.4 for ; Tue, 05 Jun 2012 15:05:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=KEUuSb8CzG2KEDVegBVSlKEHd1DUDVr7yAYxRk3yEMc=; b=x5utthGaCY0/STgW4d1J11wR27lZ9+/y56D0Rq6kIf4fTVKX/B6TwZ2mCsbfQ+Z1Tz 7r3SYtOBpMipyLcI7CiK8lXWHsku5i6Rrl8Psrukk5XRRcv++kzE6qcMEefsLFQWWjpY Dwv55ob1vfgOHTC1bSmUAKWQDlW0GYoXCAfA6I+xV39yLVmGAFfQ5dQkKohDxfoBdU7F XB45keGoDBifNGcl5+h0fmjbg0BzNNRd3f3gEE9bUbL+kgky7v9Vp0/d3Y5y57OskiNS LEPu6ovOfuwGddT9OJk50mZvJ+SYbgMUCz69ileIVjzWgimAe1LTTYxdDqdFsl0E2mW/ Firw== Received: by 10.68.190.10 with SMTP id gm10mr4554791pbc.163.1338933910332; Tue, 05 Jun 2012 15:05:10 -0700 (PDT) Received: from yakj.usersys.redhat.com (222-151-096-013.jp.fiberbit.net. [222.151.96.13]) by mx.google.com with ESMTPS id ok6sm108065pbb.29.2012.06.05.15.05.08 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 05 Jun 2012 15:05:09 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Wed, 6 Jun 2012 00:04:50 +0200 Message-Id: <1338933895-20677-3-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.7.10.1 In-Reply-To: <1338933895-20677-1-git-send-email-pbonzini@redhat.com> References: <1338933895-20677-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.210.45 Cc: kwolf@redhat.com Subject: [Qemu-devel] [PATCH v3 2/7] savevm: flush after saving vm state X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Writing vm state uses bdrv_pwrite, so it will automatically get flushes in writethrough mode. But doing a flush at the end in writeback mode is probably a good idea anyway. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- savevm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/savevm.c b/savevm.c index 2d18bab..2b6833d 100644 --- a/savevm.c +++ b/savevm.c @@ -400,7 +400,7 @@ static int block_get_buffer(void *opaque, uint8_t *buf, int64_t pos, int size) static int bdrv_fclose(void *opaque) { - return 0; + return bdrv_flush(opaque); } static QEMUFile *qemu_fopen_bdrv(BlockDriverState *bs, int is_writable)