From patchwork Tue Jun 5 14:25:49 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 163088 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id DF05BB6EF3 for ; Wed, 6 Jun 2012 00:26:13 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1339511174; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Date: From:To:Cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=IzpZT2Xr8OoSwD/V7Bzmgy91S54=; b=s6YJlAcmdC7mUWr /767q7CEE4nc/1trd8Niw/bcGeEvLfs5pP+gksv2Miipf05TXvYUvrHOkx3ahuOM rTz/LCiF+3WdjwNk/UoYJBbdj8VEqOHAY1tMGFGTfQ2zlYaIl2nM5XjQ4PHxHhHi l0Ya/Jpe3FTT5iVJnuSPzwmweB9k= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Date:From:To:Cc:Subject:In-Reply-To:Message-ID:References:MIME-Version:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=MZkHhRLV1PQJHk4CxG96AY68JVvtyEm0bNzucnw53zYbP9LAU2ZKSc4l4vaLEp uuWLdSc9Or5r/bMLs5zLNgoQirfbyUIKCi+a2EVJaYtP7chG4K8w68uWPdJd4tfb BJV0ED0cgqofEjUHO4Kqi5SWa7ogSGxgSCA+xkJXL4b8A=; Received: (qmail 11053 invoked by alias); 5 Jun 2012 14:26:09 -0000 Received: (qmail 11000 invoked by uid 22791); 5 Jun 2012 14:26:08 -0000 X-SWARE-Spam-Status: No, hits=-6.0 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_THREADED, RCVD_IN_DNSWL_HI, TW_NX, TW_TM, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Jun 2012 14:25:51 +0000 Received: from relay1.suse.de (unknown [195.135.220.254]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id EE2E3A24C0; Tue, 5 Jun 2012 16:25:49 +0200 (CEST) Date: Tue, 5 Jun 2012 16:25:49 +0200 (CEST) From: Richard Guenther To: Nathan Froyd Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix part of PR30442 In-Reply-To: Message-ID: References: <20120605132159.GA3404@nightcrawler> MIME-Version: 1.0 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Tue, 5 Jun 2012, Richard Guenther wrote: > On Tue, 5 Jun 2012, Nathan Froyd wrote: > > > On Tue, Jun 05, 2012 at 02:35:30PM +0200, Richard Guenther wrote: > > > Index: gcc/tree-vect-data-refs.c > > > ! gimple stmt = gsi_stmt (gsi); > > > ! if (!find_data_references_in_stmt (NULL, stmt, > > > ! &BB_VINFO_DATAREFS (bb_vinfo))) > > > ! { > > > ! /* Mark the rest of the basic-block as unvectorizable. */ > > > ! for (; !gsi_end_p (gsi); gsi_next (&gsi)) > > > > I see iteration through the rest of the basic block... > > > > > ! STMT_VINFO_VECTORIZABLE (vinfo_for_stmt (stmt)) = false; > > > > ...but I don't see corresponding updates to stmt. > > Eh ... > > fix in testing. Tested on x86_64-unknown-linxu-gnu, applied. Richard. 2012-06-05 Richard Guenther * tree-vect-data-refs.c (vect_analyze_data_refs): Fix last change. Index: gcc/tree-vect-data-refs.c =================================================================== --- gcc/tree-vect-data-refs.c (revision 188235) +++ gcc/tree-vect-data-refs.c (working copy) @@ -2855,7 +2855,10 @@ vect_analyze_data_refs (loop_vec_info lo { /* Mark the rest of the basic-block as unvectorizable. */ for (; !gsi_end_p (gsi); gsi_next (&gsi)) - STMT_VINFO_VECTORIZABLE (vinfo_for_stmt (stmt)) = false; + { + stmt = gsi_stmt (gsi); + STMT_VINFO_VECTORIZABLE (vinfo_for_stmt (stmt)) = false; + } break; } }