From patchwork Tue Jun 5 10:16:29 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Paul Bolle X-Patchwork-Id: 163059 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 9897FB6FA2 for ; Tue, 5 Jun 2012 20:19:48 +1000 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Sbqor-0006xQ-6W; Tue, 05 Jun 2012 10:16:57 +0000 Received: from cpsmtpb-ews03.kpnxchange.com ([213.75.39.6]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Sbqom-0006sU-H3 for linux-arm-kernel@lists.infradead.org; Tue, 05 Jun 2012 10:16:54 +0000 Received: from cpsps-ews06.kpnxchange.com ([10.94.84.173]) by cpsmtpb-ews03.kpnxchange.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 5 Jun 2012 12:16:29 +0200 Received: from CPSMTPM-TLF103.kpnxchange.com ([195.121.3.6]) by cpsps-ews06.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Tue, 5 Jun 2012 12:16:29 +0200 Received: from [192.168.1.102] ([212.123.169.34]) by CPSMTPM-TLF103.kpnxchange.com with Microsoft SMTPSVC(7.5.7601.17514); Tue, 5 Jun 2012 12:16:29 +0200 Message-ID: <1338891389.4971.45.camel@x61.thuisdomein> Subject: [PATCH v2] ARM: mach-shmobile: set i2c_board_info.type once From: Paul Bolle To: Paul Mundt , Magnus Damm , Russell King Date: Tue, 05 Jun 2012 12:16:29 +0200 X-Mailer: Evolution 3.2.3 (3.2.3-3.fc16) Mime-Version: 1.0 X-OriginalArrivalTime: 05 Jun 2012 10:16:29.0263 (UTC) FILETIME=[45BE1DF0:01CD4304] X-RcptDomain: lists.infradead.org X-Spam-Note: CRM114 invocation failed X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (pebolle[at]tiscali.nl) -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [213.75.39.6 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Sascha Hauer , Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org tsc_device (of struct i2cboard_info) has its "type" member set to "tsc2007" twice. First through the I2C_BOARD_INFO macro and then directly. Drop the superfluous second instance. Signed-off-by: Paul Bolle --- 0) v1 was called "Drop superfluous setting of i2c_board_info.type". v2 drops the mach-imx bits. Those were already fixed with a patch called "ARM: imx: only specify i2c device type once" by Uwe Kleine-König. Sascha Hauer has committed that patch to some unknown to me branch. Rebased onto v3.5-rc1. 1) Still entirely untested. I'm unsure what toolchain is needed to compile this and I'm certain that I don't have the hardware. arch/arm/mach-shmobile/board-ap4evb.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-shmobile/board-ap4evb.c b/arch/arm/mach-shmobile/board-ap4evb.c index ace6024..b9f3122 100644 --- a/arch/arm/mach-shmobile/board-ap4evb.c +++ b/arch/arm/mach-shmobile/board-ap4evb.c @@ -1197,7 +1197,6 @@ static struct tsc2007_platform_data tsc2007_info = { static struct i2c_board_info tsc_device = { I2C_BOARD_INFO("tsc2007", 0x48), - .type = "tsc2007", .platform_data = &tsc2007_info, /*.irq is selected on ap4evb_init */ };