| Message ID | 1338824270-9222-2-git-send-email-peppe.cavallaro@st.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Giuseppe CAVALLARO <peppe.cavallaro@st.com> Date: Mon, 4 Jun 2012 17:37:47 +0200 > This patch removes two useful initialisation in the > stmmac_rx and stmmac_tx function. > In the former, count var was already reset and in the > stmmac_tx we only need to increment the dirty pointer > w/o setting the entry var. > > Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com> There are so many problems with this patch I do not know where to start. Your subject line says the initializations are "useless" yet your commit message says they are "useful". This is a cleanup, and does not fix any bugs, and is therefore absolutely not appropriate for the 'net' tree. I'm tossing this entire series, you need to be more careful with your submissions. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 6/4/2012 5:49 PM, David Miller wrote: > From: Giuseppe CAVALLARO <peppe.cavallaro@st.com> > Date: Mon, 4 Jun 2012 17:37:47 +0200 > >> This patch removes two useful initialisation in the >> stmmac_rx and stmmac_tx function. >> In the former, count var was already reset and in the >> stmmac_tx we only need to increment the dirty pointer >> w/o setting the entry var. >> >> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com> > > There are so many problems with this patch I do not know where > to start. > > Your subject line says the initializations are "useless" yet > your commit message says they are "useful". Sorry, I meant "useless". > This is a cleanup, and does not fix any bugs, and is therefore > absolutely not appropriate for the 'net' tree. Yes this is not a fix but a cleanup. I've not clear where I have to post this patch. Do you mean, w/o net.git entry in the patch subject? Can you tell me what I have to do? So will resend all the patches again but I'll be more careful on all. > I'm tossing this entire series, you need to be more careful > with your submissions. ok, thanks a lot. peppe > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Giuseppe CAVALLARO <peppe.cavallaro@st.com> Date: Mon, 04 Jun 2012 17:58:18 +0200 > I've not clear where I have to post this patch. This is mind boggling that you can't figure this out. If I tell you it's not appropriate for net, that means it obviously must go to net-next -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 6/4/2012 6:01 PM, David Miller wrote: > From: Giuseppe CAVALLARO <peppe.cavallaro@st.com> > Date: Mon, 04 Jun 2012 17:58:18 +0200 > >> I've not clear where I have to post this patch. > > This is mind boggling that you can't figure this out. > > If I tell you it's not appropriate for net, that means > it obviously must go to net-next I'm sending all the patches: I have verified that there are no issues while building net.git and net-next and re-looked at all my comments and subjects. peppe > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 7096633..0caae72 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -677,7 +677,7 @@ static void stmmac_tx(struct stmmac_priv *priv) priv->hw->desc->release_tx_desc(p); - entry = (++priv->dirty_tx) % txsize; + priv->dirty_tx++; } if (unlikely(netif_queue_stopped(priv->dev) && stmmac_tx_avail(priv) > STMMAC_TX_THRESH(priv))) { @@ -1307,7 +1307,6 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit) display_ring(priv->dma_rx, rxsize); } #endif - count = 0; while (!priv->hw->desc->get_rx_owner(p)) { int status;
This patch removes two useful initialisation in the stmmac_rx and stmmac_tx function. In the former, count var was already reset and in the stmmac_tx we only need to increment the dirty pointer w/o setting the entry var. Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)