From patchwork Mon Jun 4 03:18:18 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tao Ma X-Patchwork-Id: 162616 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E118AB6F77 for ; Mon, 4 Jun 2012 13:18:32 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755683Ab2FDDSb (ORCPT ); Sun, 3 Jun 2012 23:18:31 -0400 Received: from oproxy9.bluehost.com ([69.89.24.6]:48593 "HELO oproxy9.bluehost.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755614Ab2FDDSa (ORCPT ); Sun, 3 Jun 2012 23:18:30 -0400 Received: (qmail 26148 invoked by uid 0); 4 Jun 2012 03:18:30 -0000 Received: from unknown (HELO box585.bluehost.com) (66.147.242.185) by oproxy9.bluehost.com with SMTP; 4 Jun 2012 03:18:30 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tao.ma; s=default; h=Message-Id:Date:Subject:Cc:To:From; bh=GQWeMb5sFX2VkBd4qhtadx/POj18Def0XoCvGFEwP1U=; b=cGmFjRCR4xfRESvlrGnt/omQB6HO10jbhpD2LcrphNCYUUiFjIlxbmHG7IbBgD2BhktBZ4bv1xxTapcOZc6iVOq2ZTJ+nHgOalryjqbCymj5a+FacmapBLS033vcvNcU; Received: from [182.92.247.2] (port=29957 helo=tma-laptop1.taobao.ali.com) by box585.bluehost.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.76) (envelope-from ) id 1SbNoL-0000Dn-ML; Sun, 03 Jun 2012 21:18:30 -0600 From: Tao Ma To: linux-ext4@vger.kernel.org Cc: "Theodore Ts'o" Subject: [PATCH] ext4: Don't set i_flags in EXT4_IOC_SETFLAGS. Date: Mon, 4 Jun 2012 11:18:18 +0800 Message-Id: <1338779898-3146-1-git-send-email-tm@tao.ma> X-Mailer: git-send-email 1.7.4.1 X-Identified-User: {1390:box585.bluehost.com:colyli:tao.ma} {sentby:smtp auth 182.92.247.2 authed with tm@tao.ma} Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Tao Ma 7990696 uses the ext4_{set,clear}_inode_flags() functions to change the i_flags automatically but fails to remove the error setting of i_flags. So we still have the problem of trashing state flags. So remove it. Cc: "Theodore Ts'o" Signed-off-by: Tao Ma --- fs/ext4/ioctl.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c index 8ad112a..e34deac 100644 --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c @@ -123,7 +123,6 @@ long ext4_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) else ext4_clear_inode_flag(inode, i); } - ei->i_flags = flags; ext4_set_inode_flags(inode); inode->i_ctime = ext4_current_time(inode);