Patchwork [1/1] libcgi: fix cflags

login
register
mail settings
Submitter Samuel Martin
Date June 3, 2012, 3:15 p.m.
Message ID <1338736512-21375-1-git-send-email-s.martin49@gmail.com>
Download mbox | patch
Permalink /patch/162550/
State Accepted
Commit 7ab39d39cbbf93dbd59e7a0fdb1a1f5ee7962034
Headers show

Comments

Samuel Martin - June 3, 2012, 3:15 p.m.
Fixes http://autobuild.buildroot.org/results/4000a12a9b237bd12618eb22ea793a913fc73b4f

Signed-off-by: Samuel Martin <s.martin49@gmail.com>
---
 package/libcgi/libcgi.patch |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Peter Korsgaard - June 5, 2012, 9:17 p.m.
>>>>> "Samuel" == Samuel Martin <s.martin49@gmail.com> writes:

 Samuel> Fixes http://autobuild.buildroot.org/results/4000a12a9b237bd12618eb22ea793a913fc73b4f
 Samuel> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
 Samuel> ---
 Samuel>  package/libcgi/libcgi.patch |    2 +-
 Samuel>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, could you please add a git-style header with description and
your signed-off-by to this patch (and perhaps a more descriptive file
name)?

 Samuel> diff --git a/package/libcgi/libcgi.patch b/package/libcgi/libcgi.patch
 Samuel> index 716d83c..12a7b10 100644
 Samuel> --- a/package/libcgi/libcgi.patch
 Samuel> +++ b/package/libcgi/libcgi.patch
 Samuel> @@ -27,7 +27,7 @@
 Samuel>   exec_prefix = @exec_prefix@
  
 Samuel>  -SHAREDOPT = -shared
 Samuel> -+SHAREDOPT = -shared -fPIC,-Wl,-soname,libcgi.so.0
 Samuel> ++SHAREDOPT = -shared -fPIC -Wl,-soname,libcgi.so.0
 Samuel>   LIBDIR = $(prefix)/lib
 Samuel>  -INCDIR = $(prefix)/include
 Samuel>  +INCDIR = $(prefix)/include/libcgi/
 Samuel> -- 
 Samuel> 1.7.10.3

 Samuel> _______________________________________________
 Samuel> buildroot mailing list
 Samuel> buildroot@busybox.net
 Samuel> http://lists.busybox.net/mailman/listinfo/buildroot
Peter Korsgaard - June 5, 2012, 10:49 p.m.
>>>>> "Samuel" == Samuel Martin <s.martin49@gmail.com> writes:

 Samuel> Fixes http://autobuild.buildroot.org/results/4000a12a9b237bd12618eb22ea793a913fc73b4f
 Samuel> Signed-off-by: Samuel Martin <s.martin49@gmail.com>

Committed, thanks.

Patch

diff --git a/package/libcgi/libcgi.patch b/package/libcgi/libcgi.patch
index 716d83c..12a7b10 100644
--- a/package/libcgi/libcgi.patch
+++ b/package/libcgi/libcgi.patch
@@ -27,7 +27,7 @@ 
  exec_prefix = @exec_prefix@
  
 -SHAREDOPT = -shared
-+SHAREDOPT = -shared -fPIC,-Wl,-soname,libcgi.so.0
++SHAREDOPT = -shared -fPIC -Wl,-soname,libcgi.so.0
  LIBDIR = $(prefix)/lib
 -INCDIR = $(prefix)/include
 +INCDIR = $(prefix)/include/libcgi/