From patchwork Sat Jun 2 01:52:28 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: asharif@chromium.org X-Patchwork-Id: 162397 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 28A4CB700E for ; Sat, 2 Jun 2012 11:52:49 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1339206770; h=Comment: DomainKey-Signature:Received:Received:Received:Received: MIME-Version:Received:Reply-To:Message-ID:Date:Subject:From:To: Cc:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=PYkbsmh //O7wQ6tVWS/0HNGrs8M=; b=ea2KLyLrZGAm9+jfkdiht+MzxWbNHf11Ik+1OWo cAvkVsDPmwxT4YQEmc4KenYPnC+33CPL60eEGklgjp2d1eiruCj3DOWx5R3sVIqt cmlpNqgw9FDKaLaNg9Y5ZrZU1l9qpOwbp2agDBv3W5ERNk84pC/J2jSZtje5hqhK 86hk= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:MIME-Version:Received:Reply-To:X-Google-Appengine-App-Id:Message-ID:Date:Subject:From:To:Cc:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=PGJA3LT8mFSVKWSn9fAG04yqN7he9h52lOPr1nLMr3baXNr2yv7MqgdckcqoHe fcuWc1FYTgDXsscvAQdWkD5fFNxTUB1CNPZ25s7dE0a2zJakjjMYcC3sXV+BZ/U1 EHwGfuEaLXqa5ivXNUFBp37DVOlyRhArhS5gq7urYBvxY=; Received: (qmail 23097 invoked by alias); 2 Jun 2012 01:52:44 -0000 Received: (qmail 23087 invoked by uid 22791); 2 Jun 2012 01:52:42 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-vb0-f69.google.com (HELO mail-vb0-f69.google.com) (209.85.212.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 02 Jun 2012 01:52:29 +0000 Received: by vbbez10 with SMTP id ez10so4285280vbb.8 for ; Fri, 01 Jun 2012 18:52:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.224.186.17 with SMTP id cq17mr3302622qab.6.1338601948862; Fri, 01 Jun 2012 18:52:28 -0700 (PDT) Reply-To: asharif@chromium.org, davidxl@google.com, xur@google.com, bjanakiraman@google.com, gcc-patches@gcc.gnu.org, reply@codereview-hr.appspotmail.com X-Google-Appengine-App-Id: s~codereview-hr Message-ID: <20cf30334f1ba85ba104c1738d3a@google.com> Date: Sat, 02 Jun 2012 01:52:28 +0000 Subject: [google/main] Copy TREE_STATIC() property from id in dwarf2asm.c (issue 6273045) From: asharif@chromium.org To: davidxl@google.com, xur@google.com, bjanakiraman@google.com Cc: gcc-patches@gcc.gnu.org, reply@codereview-hr.appspotmail.com Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Reviewers: davidxl, xur, bjanakiraman_google.com, Message: A trunk version of this patch is already under review. I'm creating this CL in order to get this patch in before the branch date. Please review this at http://codereview.appspot.com/6273045/ Affected files: M gcc/ChangeLog.google-main M gcc/dwarf2asm.c Index: gcc/dwarf2asm.c =================================================================== --- gcc/dwarf2asm.c (revision 188129) +++ gcc/dwarf2asm.c (working copy) @@ -907,6 +907,7 @@ DECL_IGNORED_P (decl) = 1; DECL_INITIAL (decl) = decl; TREE_READONLY (decl) = 1; + TREE_STATIC (decl) = TREE_STATIC(id); if (TREE_PUBLIC (id)) { @@ -915,8 +916,6 @@ if (USE_LINKONCE_INDIRECT) DECL_VISIBILITY (decl) = VISIBILITY_HIDDEN; } - else - TREE_STATIC (decl) = 1; sym_ref = gen_rtx_SYMBOL_REF (Pmode, sym); assemble_variable (decl, 1, 1, 1); Index: gcc/ChangeLog.google-main =================================================================== --- gcc/ChangeLog.google-main (revision 188129) +++ gcc/ChangeLog.google-main (working copy) @@ -1,3 +1,8 @@ +2012-06-01 Ahmad Sharif + + * gcc/dwarf2asm.c: (dw2_output_indirect_constant_1) copy the TREE_STATIC + attribute from id to decl. + 2012-05-30 Dehao Chen * predict.c (predict_extra_loop_exit): New function to predict for