Patchwork [trunk] Copy TREE_STATIC() property from id in dwarf2asm.c (issue 6133061)

login
register
mail settings
Submitter asharif@chromium.org
Date June 1, 2012, 12:10 a.m.
Message ID <20cf303b40bf500ae404c15e0236@google.com>
Download mbox | patch
Permalink /patch/162246/
State New
Headers show

Comments

asharif@chromium.org - June 1, 2012, 12:10 a.m.
Reviewers: xur, davidxl, iant2, Diego Novillo,

Message:
The relevant bug is this:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53546.

Please take a look and provide feedback.

Thanks,

Description:
2012-05-31   Ahmad Sharif  <asharif@google.com>

	* gcc/dwarf2asm.c: (dw2_output_indirect_constant_1): Copy TREE_STATIC()
	attribute from id to decl.
Diego Novillo - June 5, 2012, 1:16 p.m.
On Thu, May 31, 2012 at 8:10 PM,  <asharif@chromium.org> wrote:
> Reviewers: xur, davidxl, iant2, Diego Novillo,
>
> Message:
> The relevant bug is this:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53546.

This bug does not affect trunk.  Only the google branches where LIPO
is implemented.


Diego.

Patch

Index: gcc/dwarf2asm.c
===================================================================
--- gcc/dwarf2asm.c	(revision 188089)
+++ gcc/dwarf2asm.c	(working copy)
@@ -907,6 +907,7 @@ 
    DECL_IGNORED_P (decl) = 1;
    DECL_INITIAL (decl) = decl;
    TREE_READONLY (decl) = 1;
+  TREE_STATIC (decl) = TREE_STATIC (id);

    if (TREE_PUBLIC (id))
      {
@@ -915,8 +916,6 @@ 
        if (USE_LINKONCE_INDIRECT)
  	DECL_VISIBILITY (decl) = VISIBILITY_HIDDEN;
      }
-  else
-    TREE_STATIC (decl) = 1;

    sym_ref = gen_rtx_SYMBOL_REF (Pmode, sym);
    assemble_variable (decl, 1, 1, 1);


Please review this at http://codereview.appspot.com/6133061/

Affected files:
   M     gcc/dwarf2asm.c


2012-04-30   Ahmad Sharif  <asharif@google.com>

	* gcc/dwarf2asm.c: copy TREE_STATIC() property from id.

Index: gcc/dwarf2asm.c
===================================================================
--- gcc/dwarf2asm.c	(revision 186998)
+++ gcc/dwarf2asm.c	(working copy)
@@ -907,6 +907,7 @@ 
    DECL_IGNORED_P (decl) = 1;
    DECL_INITIAL (decl) = decl;
    TREE_READONLY (decl) = 1;
+  TREE_STATIC (decl) = TREE_STATIC (id);

    if (TREE_PUBLIC (id))
      {
@@ -915,8 +916,6 @@ 
        if (USE_LINKONCE_INDIRECT)
  	DECL_VISIBILITY (decl) = VISIBILITY_HIDDEN;
      }
-  else
-    TREE_STATIC (decl) = 1;

    sym_ref = gen_rtx_SYMBOL_REF (Pmode, sym);
    assemble_variable (decl, 1, 1, 1);