Patchwork mke2fs: enable bigalloc if -C is specified

login
register
mail settings
Submitter Eric Sandeen
Date May 31, 2012, 4:52 p.m.
Message ID <4FC7A1D5.3040805@redhat.com>
Download mbox | patch
Permalink /patch/162194/
State New
Headers show

Comments

Eric Sandeen - May 31, 2012, 4:52 p.m.
If -C is specified w/o -O bigalloc it has no effect and generates
no error.  If a cluster size is specified, that should imply
bigalloc.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---



--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Eric Sandeen - May 31, 2012, 8:44 p.m.
On 5/31/12 11:52 AM, Eric Sandeen wrote:
> If -C is specified w/o -O bigalloc it has no effect and generates
> no error.  If a cluster size is specified, that should imply
> bigalloc.

Hm, so should -O bigalloc even be supported (or documented), or should
this always be done via -C XXXX?  It seems better to specify the size
rather than have some other -O option which picks an (arbitrary?) default
of 16x.

I'm also wondering what kind of guidance we should offer for choosing
cluster sizes - or if we should default to a cluster size given either
fs size, inode count, or combinations thereof.

I think the hard cold truth is that ext4 just isn't sufficiently scalable
at larger sizes without a larger cluster size, so I'm inclined to start
thinking about choosing some increasing cluster sizes as defaults, what
do you think?

And finally, is this stuff robust enough to start documenting in
the manpages yet?  I'm not sure the enospc problems have been worked
out yet...

-Eric

> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
> 
> diff --git a/misc/mke2fs.c b/misc/mke2fs.c
> index 7ec8cc2..d1944dc 100644
> --- a/misc/mke2fs.c
> +++ b/misc/mke2fs.c
> @@ -1351,6 +1351,8 @@ profile_error:
>  					optarg);
>  				exit(1);
>  			}
> +			fs_param.s_feature_ro_compat |=
> +					EXT4_FEATURE_RO_COMPAT_BIGALLOC;
>  			break;
>  		case 'D':
>  			direct_io = 1;
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/misc/mke2fs.c b/misc/mke2fs.c
index 7ec8cc2..d1944dc 100644
--- a/misc/mke2fs.c
+++ b/misc/mke2fs.c
@@ -1351,6 +1351,8 @@  profile_error:
 					optarg);
 				exit(1);
 			}
+			fs_param.s_feature_ro_compat |=
+					EXT4_FEATURE_RO_COMPAT_BIGALLOC;
 			break;
 		case 'D':
 			direct_io = 1;