Patchwork [3/4] lib: fwts_log_html: tweak style and table format

login
register
mail settings
Submitter Colin King
Date May 31, 2012, 12:42 p.m.
Message ID <1338468129-5491-4-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/162150/
State Accepted
Headers show

Comments

Colin King - May 31, 2012, 12:42 p.m.
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/lib/src/fwts_log_html.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Keng-Yu Lin - June 4, 2012, 8:34 a.m.
On Thu, May 31, 2012 at 8:42 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/src/fwts_log_html.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/src/lib/src/fwts_log_html.c b/src/lib/src/fwts_log_html.c
> index 25f81ef..d293dbc 100644
> --- a/src/lib/src/fwts_log_html.c
> +++ b/src/lib/src/fwts_log_html.c
> @@ -266,11 +266,12 @@ static void fwts_log_open_html(fwts_log *log)
>                "text-align: center; vertical-align: center }\n"
>                ".style_subtest { background-color: lightgray; }\n"
>                ".style_info { }\n"
> -               ".style_code { font-family=sans-mono; line-height: 70% }\n");
> +               ".style_code { font-family: \"courier\",\"mono\"; font-size:0.75em; overflow:auto; "
> +               "width:90%; line-height:0.82em; font-stretch:extra-condensed; word-wrap:normal }\n");
>        fwts_log_html(log, "</STYLE>\n");
>        fflush(log->fp);
>
> -       fwts_log_html(log, "<TABLE>\n");
> +       fwts_log_html(log, "<TABLE WIDTH=1024>\n");
>        fwts_log_html(log, "</TR>\n");
>
>        fwts_log_section_begin_html(log, "fwts");
> --
> 1.7.9.5
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - June 6, 2012, 4:12 a.m.
On 05/31/2012 08:42 PM, Colin King wrote:
> From: Colin Ian King<colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King<colin.king@canonical.com>
> ---
>   src/lib/src/fwts_log_html.c |    5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/src/lib/src/fwts_log_html.c b/src/lib/src/fwts_log_html.c
> index 25f81ef..d293dbc 100644
> --- a/src/lib/src/fwts_log_html.c
> +++ b/src/lib/src/fwts_log_html.c
> @@ -266,11 +266,12 @@ static void fwts_log_open_html(fwts_log *log)
>   		"text-align: center; vertical-align: center }\n"
>   		".style_subtest { background-color: lightgray; }\n"
>   		".style_info { }\n"
> -		".style_code { font-family=sans-mono; line-height: 70% }\n");
> +		".style_code { font-family: \"courier\",\"mono\"; font-size:0.75em; overflow:auto; "
> +		"width:90%; line-height:0.82em; font-stretch:extra-condensed; word-wrap:normal }\n");
>   	fwts_log_html(log, "</STYLE>\n");
>   	fflush(log->fp);
>
> -	fwts_log_html(log, "<TABLE>\n");
> +	fwts_log_html(log, "<TABLE WIDTH=1024>\n");
>   	fwts_log_html(log, "</TR>\n");
>
>   	fwts_log_section_begin_html(log, "fwts");
Acked-by: Ivan Hu<ivan.hu@canonical.com>
Chris Van Hoof - June 11, 2012, 3:59 p.m.
On 05/31/2012 08:42 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/src/fwts_log_html.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/src/lib/src/fwts_log_html.c b/src/lib/src/fwts_log_html.c
> index 25f81ef..d293dbc 100644
> --- a/src/lib/src/fwts_log_html.c
> +++ b/src/lib/src/fwts_log_html.c
> @@ -266,11 +266,12 @@ static void fwts_log_open_html(fwts_log *log)
>  		"text-align: center; vertical-align: center }\n"
>  		".style_subtest { background-color: lightgray; }\n"
>  		".style_info { }\n"
> -		".style_code { font-family=sans-mono; line-height: 70% }\n");
> +		".style_code { font-family: \"courier\",\"mono\"; font-size:0.75em; overflow:auto; "
> +		"width:90%; line-height:0.82em; font-stretch:extra-condensed; word-wrap:normal }\n");
>  	fwts_log_html(log, "</STYLE>\n");
>  	fflush(log->fp);
>  
> -	fwts_log_html(log, "<TABLE>\n");
> +	fwts_log_html(log, "<TABLE WIDTH=1024>\n");
>  	fwts_log_html(log, "</TR>\n");
>  
>  	fwts_log_section_begin_html(log, "fwts");

Tested-by: Chris Van Hoof <vanhoof@canonical.com>

Patch

diff --git a/src/lib/src/fwts_log_html.c b/src/lib/src/fwts_log_html.c
index 25f81ef..d293dbc 100644
--- a/src/lib/src/fwts_log_html.c
+++ b/src/lib/src/fwts_log_html.c
@@ -266,11 +266,12 @@  static void fwts_log_open_html(fwts_log *log)
 		"text-align: center; vertical-align: center }\n"
 		".style_subtest { background-color: lightgray; }\n"
 		".style_info { }\n"
-		".style_code { font-family=sans-mono; line-height: 70% }\n");
+		".style_code { font-family: \"courier\",\"mono\"; font-size:0.75em; overflow:auto; "
+		"width:90%; line-height:0.82em; font-stretch:extra-condensed; word-wrap:normal }\n");
 	fwts_log_html(log, "</STYLE>\n");
 	fflush(log->fp);
 
-	fwts_log_html(log, "<TABLE>\n");
+	fwts_log_html(log, "<TABLE WIDTH=1024>\n");
 	fwts_log_html(log, "</TR>\n");
 
 	fwts_log_section_begin_html(log, "fwts");