Patchwork [2/4] lib: fwts_memorymap: output should be in verbatum style

login
register
mail settings
Submitter Colin King
Date May 31, 2012, 12:42 p.m.
Message ID <1338468129-5491-3-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/162147/
State Accepted
Headers show

Comments

Colin King - May 31, 2012, 12:42 p.m.
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/lib/src/fwts_memorymap.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Keng-Yu Lin - June 4, 2012, 8:34 a.m.
On Thu, May 31, 2012 at 8:42 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/src/fwts_memorymap.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/lib/src/fwts_memorymap.c b/src/lib/src/fwts_memorymap.c
> index 6625679..a0ca16f 100644
> --- a/src/lib/src/fwts_memorymap.c
> +++ b/src/lib/src/fwts_memorymap.c
> @@ -201,7 +201,7 @@ static void fwts_memory_map_dump_info(void *data, void *private)
>        fwts_memory_map_entry *entry = (fwts_memory_map_entry *)data;
>        fwts_framework *fw = (fwts_framework *)private;
>
> -       fwts_log_info(fw, "%016llx - %016llx  %s",
> +       fwts_log_info_verbatum(fw, "%016llx - %016llx  %s",
>                        (unsigned long long)entry->start_address,
>                        (unsigned long long)entry->end_address,
>                        fwts_memory_map_type_to_str(entry->type));
> @@ -213,8 +213,8 @@ static void fwts_memory_map_dump_info(void *data, void *private)
>  */
>  void fwts_memory_map_table_dump(fwts_framework *fw, fwts_list *memory_map_list)
>  {
> -       fwts_log_info(fw, "Memory Map Layout");
> -       fwts_log_info(fw, "-----------------");
> +       fwts_log_info_verbatum(fw, "Memory Map Layout");
> +       fwts_log_info_verbatum(fw, "-----------------");
>
>        fwts_list_iterate(memory_map_list, fwts_memory_map_dump_info, fw);
>  }
> --
> 1.7.9.5
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - June 6, 2012, 4:12 a.m.
On 05/31/2012 08:42 PM, Colin King wrote:
> From: Colin Ian King<colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King<colin.king@canonical.com>
> ---
>   src/lib/src/fwts_memorymap.c |    6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/lib/src/fwts_memorymap.c b/src/lib/src/fwts_memorymap.c
> index 6625679..a0ca16f 100644
> --- a/src/lib/src/fwts_memorymap.c
> +++ b/src/lib/src/fwts_memorymap.c
> @@ -201,7 +201,7 @@ static void fwts_memory_map_dump_info(void *data, void *private)
>   	fwts_memory_map_entry *entry = (fwts_memory_map_entry *)data;
>   	fwts_framework *fw = (fwts_framework *)private;
>
> -	fwts_log_info(fw, "%016llx - %016llx  %s",
> +	fwts_log_info_verbatum(fw, "%016llx - %016llx  %s",
>   			(unsigned long long)entry->start_address,
>   			(unsigned long long)entry->end_address,
>   			fwts_memory_map_type_to_str(entry->type));
> @@ -213,8 +213,8 @@ static void fwts_memory_map_dump_info(void *data, void *private)
>    */
>   void fwts_memory_map_table_dump(fwts_framework *fw, fwts_list *memory_map_list)
>   {
> -	fwts_log_info(fw, "Memory Map Layout");
> -	fwts_log_info(fw, "-----------------");
> +	fwts_log_info_verbatum(fw, "Memory Map Layout");
> +	fwts_log_info_verbatum(fw, "-----------------");
>
>   	fwts_list_iterate(memory_map_list, fwts_memory_map_dump_info, fw);
>   }
Acked-by: Ivan Hu<ivan.hu@canonical.com>
Chris Van Hoof - June 11, 2012, 3:59 p.m.
On 05/31/2012 08:42 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/src/fwts_memorymap.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/lib/src/fwts_memorymap.c b/src/lib/src/fwts_memorymap.c
> index 6625679..a0ca16f 100644
> --- a/src/lib/src/fwts_memorymap.c
> +++ b/src/lib/src/fwts_memorymap.c
> @@ -201,7 +201,7 @@ static void fwts_memory_map_dump_info(void *data, void *private)
>  	fwts_memory_map_entry *entry = (fwts_memory_map_entry *)data;
>  	fwts_framework *fw = (fwts_framework *)private;
>  
> -	fwts_log_info(fw, "%016llx - %016llx  %s",
> +	fwts_log_info_verbatum(fw, "%016llx - %016llx  %s",
>  			(unsigned long long)entry->start_address,
>  			(unsigned long long)entry->end_address,
>  			fwts_memory_map_type_to_str(entry->type));
> @@ -213,8 +213,8 @@ static void fwts_memory_map_dump_info(void *data, void *private)
>   */
>  void fwts_memory_map_table_dump(fwts_framework *fw, fwts_list *memory_map_list)
>  {
> -	fwts_log_info(fw, "Memory Map Layout");
> -	fwts_log_info(fw, "-----------------");
> +	fwts_log_info_verbatum(fw, "Memory Map Layout");
> +	fwts_log_info_verbatum(fw, "-----------------");
>  
>  	fwts_list_iterate(memory_map_list, fwts_memory_map_dump_info, fw);
>  }

Tested-by: Chris Van Hoof <vanhoof@canonical.com>

Patch

diff --git a/src/lib/src/fwts_memorymap.c b/src/lib/src/fwts_memorymap.c
index 6625679..a0ca16f 100644
--- a/src/lib/src/fwts_memorymap.c
+++ b/src/lib/src/fwts_memorymap.c
@@ -201,7 +201,7 @@  static void fwts_memory_map_dump_info(void *data, void *private)
 	fwts_memory_map_entry *entry = (fwts_memory_map_entry *)data;
 	fwts_framework *fw = (fwts_framework *)private;
 
-	fwts_log_info(fw, "%016llx - %016llx  %s",
+	fwts_log_info_verbatum(fw, "%016llx - %016llx  %s",
 			(unsigned long long)entry->start_address,
 			(unsigned long long)entry->end_address,
 			fwts_memory_map_type_to_str(entry->type));
@@ -213,8 +213,8 @@  static void fwts_memory_map_dump_info(void *data, void *private)
  */
 void fwts_memory_map_table_dump(fwts_framework *fw, fwts_list *memory_map_list)
 {
-	fwts_log_info(fw, "Memory Map Layout");
-	fwts_log_info(fw, "-----------------");
+	fwts_log_info_verbatum(fw, "Memory Map Layout");
+	fwts_log_info_verbatum(fw, "-----------------");
 
 	fwts_list_iterate(memory_map_list, fwts_memory_map_dump_info, fw);
 }