| Message ID | 1338465062-30660-2-git-send-email-dev@lynxeye.de |
|---|---|
| State | Accepted |
| Headers | show |
Dear Lucas Stach, > loop_count runs down from 10000, so the correct condition to error out > is ==0. > > Signed-off-by: Lucas Stach <dev@lynxeye.de> > Acked-by: Stephen Warren <swarren@wwwdotorg.org> > CC: Stephen Warren <swarren@wwwdotorg.org> > CC: Tom Warren <twarren.nvidia@gmail.com> > --- > arch/arm/cpu/armv7/tegra2/usb.c | 2 +- > 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-) > > diff --git a/arch/arm/cpu/armv7/tegra2/usb.c > b/arch/arm/cpu/armv7/tegra2/usb.c index c80de7f..5f2b243 100644 > --- a/arch/arm/cpu/armv7/tegra2/usb.c > +++ b/arch/arm/cpu/armv7/tegra2/usb.c Why isn't this file in drivers/usb/ ? > @@ -290,7 +290,7 @@ static int init_usb_controller(struct fdt_usb *config, > break; > udelay(1); > } > - if (loop_count == 100000) > + if (!loop_count) > return -1; > > return 0; Best regards, Marek Vasut
On 05/31/2012 05:51 AM, Lucas Stach wrote: > loop_count runs down from 10000, so the correct condition to error out > is ==0. > > Signed-off-by: Lucas Stach <dev@lynxeye.de> > Acked-by: Stephen Warren <swarren@wwwdotorg.org> > CC: Stephen Warren <swarren@wwwdotorg.org> > CC: Tom Warren <twarren.nvidia@gmail.com> Tested-by: Stephen Warren <swarren@wwwdotorg.org> On Harmony, repeated invocations of "usb start 0 ; dhcp ${loadaddr} zImage.uimg" appeared to work OK, with this patch applied to u-boot-tegra.git master branch.
diff --git a/arch/arm/cpu/armv7/tegra2/usb.c b/arch/arm/cpu/armv7/tegra2/usb.c index c80de7f..5f2b243 100644 --- a/arch/arm/cpu/armv7/tegra2/usb.c +++ b/arch/arm/cpu/armv7/tegra2/usb.c @@ -290,7 +290,7 @@ static int init_usb_controller(struct fdt_usb *config, break; udelay(1); } - if (loop_count == 100000) + if (!loop_count) return -1; return 0;