| Message ID | af79247f427979584f3e07753ec3ad4766844ec9.1338408931.git.joe@perches.com |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On 05/30/2012 10:25 PM, Joe Perches wrote: > Using | with a constant is always true. > Likely this should have be &. Acked-by: Arend van Spriel <arend@broadcom.com> > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c index e2480d1..8e7e692 100644 --- a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c +++ b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c @@ -89,9 +89,9 @@ int brcmf_sdio_intr_register(struct brcmf_sdio_dev *sdiodev) data |= 1 << SDIO_FUNC_1 | 1 << SDIO_FUNC_2 | 1; brcmf_sdio_regwb(sdiodev, SDIO_CCCR_IENx, data, &ret); - /* redirect, configure ane enable io for interrupt signal */ + /* redirect, configure and enable io for interrupt signal */ data = SDIO_SEPINT_MASK | SDIO_SEPINT_OE; - if (sdiodev->irq_flags | IRQF_TRIGGER_HIGH) + if (sdiodev->irq_flags & IRQF_TRIGGER_HIGH) data |= SDIO_SEPINT_ACT_HI; brcmf_sdio_regwb(sdiodev, SDIO_CCCR_BRCM_SEPINT, data, &ret);
Using | with a constant is always true. Likely this should have be &. Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)