Patchwork [3/4] lib: fwts_framework: log advice as LOG_ADVICE and not LOG_RESULT

login
register
mail settings
Submitter Colin King
Date May 30, 2012, 6:40 p.m.
Message ID <1338403238-14029-4-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/162052/
State Accepted
Headers show

Comments

Colin King - May 30, 2012, 6:40 p.m.
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/lib/src/fwts_framework.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Ivan Hu - June 1, 2012, 6:35 a.m.
On 05/31/2012 02:40 AM, Colin King wrote:
> From: Colin Ian King<colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King<colin.king@canonical.com>
> ---
>   src/lib/src/fwts_framework.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c
> index 78a715d..3f54fdb 100644
> --- a/src/lib/src/fwts_framework.c
> +++ b/src/lib/src/fwts_framework.c
> @@ -672,7 +672,7 @@ void fwts_framework_log(fwts_framework *fw,
>   	case LOG_ADVICE:
>   		fwts_log_nl(fw);
>   		snprintf(prefix, sizeof(prefix), "%s: ", str);
> -		fwts_log_printf(fw->results, LOG_RESULT, level, str, label, prefix, "%s", buffer);
> +		fwts_log_printf(fw->results, LOG_ADVICE, level, str, label, prefix, "%s", buffer);
>   		fwts_log_nl(fw);
>   		break;
>   	case LOG_FAILED:
Acked-by: Ivan Hu<ivan.hu@canonical.com>
Keng-Yu Lin - June 1, 2012, 8:48 a.m.
On Thu, May 31, 2012 at 2:40 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/src/fwts_framework.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c
> index 78a715d..3f54fdb 100644
> --- a/src/lib/src/fwts_framework.c
> +++ b/src/lib/src/fwts_framework.c
> @@ -672,7 +672,7 @@ void fwts_framework_log(fwts_framework *fw,
>        case LOG_ADVICE:
>                fwts_log_nl(fw);
>                snprintf(prefix, sizeof(prefix), "%s: ", str);
> -               fwts_log_printf(fw->results, LOG_RESULT, level, str, label, prefix, "%s", buffer);
> +               fwts_log_printf(fw->results, LOG_ADVICE, level, str, label, prefix, "%s", buffer);
>                fwts_log_nl(fw);
>                break;
>        case LOG_FAILED:
> --
> 1.7.9.5
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Chris Van Hoof - June 11, 2012, 4:04 p.m.
On 05/30/2012 02:40 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/src/fwts_framework.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c
> index 78a715d..3f54fdb 100644
> --- a/src/lib/src/fwts_framework.c
> +++ b/src/lib/src/fwts_framework.c
> @@ -672,7 +672,7 @@ void fwts_framework_log(fwts_framework *fw,
>  	case LOG_ADVICE:
>  		fwts_log_nl(fw);
>  		snprintf(prefix, sizeof(prefix), "%s: ", str);
> -		fwts_log_printf(fw->results, LOG_RESULT, level, str, label, prefix, "%s", buffer);
> +		fwts_log_printf(fw->results, LOG_ADVICE, level, str, label, prefix, "%s", buffer);
>  		fwts_log_nl(fw);
>  		break;
>  	case LOG_FAILED:

Tested-by: Chris Van Hoof <vanhoof@canonical.com>

Patch

diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c
index 78a715d..3f54fdb 100644
--- a/src/lib/src/fwts_framework.c
+++ b/src/lib/src/fwts_framework.c
@@ -672,7 +672,7 @@  void fwts_framework_log(fwts_framework *fw,
 	case LOG_ADVICE:
 		fwts_log_nl(fw);
 		snprintf(prefix, sizeof(prefix), "%s: ", str);
-		fwts_log_printf(fw->results, LOG_RESULT, level, str, label, prefix, "%s", buffer);
+		fwts_log_printf(fw->results, LOG_ADVICE, level, str, label, prefix, "%s", buffer);
 		fwts_log_nl(fw);
 		break;
 	case LOG_FAILED: