Patchwork [17/22] rtc: ab8500-rtc: IRQF_ONESHOT when requesting a threaded IRQ

login
register
mail settings
Submitter Lee Jones
Date May 30, 2012, 4:47 a.m.
Message ID <1338353260-10097-18-git-send-email-lee.jones@linaro.org>
Download mbox | patch
Permalink /patch/161840/
State New
Headers show

Comments

Lee Jones - May 30, 2012, 4:47 a.m.
The kernel now forces IRQs to be ONESHOT if no IRQ handler is passed.

Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: rtc-linux@googlegroups.com
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/rtc/rtc-ab8500.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Linus Walleij - May 30, 2012, 7:11 a.m.
On Wed, May 30, 2012 at 12:47 PM, Lee Jones <lee.jones@linaro.org> wrote:

> The kernel now forces IRQs to be ONESHOT if no IRQ handler is passed.
>
> Cc: Alessandro Zummo <a.zummo@towertech.it>
> Cc: rtc-linux@googlegroups.com
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/rtc/rtc-ab8500.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c
> index 4bcf9ca..b11a2ec 100644
> --- a/drivers/rtc/rtc-ab8500.c
> +++ b/drivers/rtc/rtc-ab8500.c
> @@ -422,7 +422,7 @@ static int __devinit ab8500_rtc_probe(struct platform_device *pdev)
>        }
>
>        err = request_threaded_irq(irq, NULL, rtc_alarm_handler,
> -               IRQF_NO_SUSPEND, "ab8500-rtc", rtc);
> +               IRQF_NO_SUSPEND | IRQF_ONESHOT, "ab8500-rtc", rtc);
>        if (err < 0) {
>                rtc_device_unregister(rtc);
>                return err;

Looks correct, Acked-by (also for the previous patch).

Linus Walleij

Patch

diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c
index 4bcf9ca..b11a2ec 100644
--- a/drivers/rtc/rtc-ab8500.c
+++ b/drivers/rtc/rtc-ab8500.c
@@ -422,7 +422,7 @@  static int __devinit ab8500_rtc_probe(struct platform_device *pdev)
 	}
 
 	err = request_threaded_irq(irq, NULL, rtc_alarm_handler,
-		IRQF_NO_SUSPEND, "ab8500-rtc", rtc);
+		IRQF_NO_SUSPEND | IRQF_ONESHOT, "ab8500-rtc", rtc);
 	if (err < 0) {
 		rtc_device_unregister(rtc);
 		return err;