Patchwork [U-Boot,01/10] mx53loco: Remove unused SOBJS

login
register
mail settings
Submitter Fabio Estevam
Date May 29, 2012, 5:39 p.m.
Message ID <1338313203-9201-1-git-send-email-fabio.estevam@freescale.com>
Download mbox | patch
Permalink /patch/161770/
State Accepted
Commit 2fb563f2f52d3e4c59c8f0c0309ea6a65c558878
Delegated to: Stefano Babic
Headers show

Comments

Fabio Estevam - May 29, 2012, 5:39 p.m.
There is no .S file in this directory, so just remove SOBJS.

Cc: Jason Liu <r64343@freescale.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 board/freescale/mx53loco/Makefile |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)
Marek Vasut - May 29, 2012, 5:54 p.m.
Dear Fabio Estevam,

> There is no .S file in this directory, so just remove SOBJS.
> 
> Cc: Marek Vasut <marex@denx.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Looks ok,

Acked-by: Marek Vasut <marex@denx.de>

> ---
>  board/efikamx/Makefile |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/board/efikamx/Makefile b/board/efikamx/Makefile
> index fdd188e..bd2174f 100644
> --- a/board/efikamx/Makefile
> +++ b/board/efikamx/Makefile
> @@ -33,12 +33,11 @@ ifdef	CONFIG_CMD_USB
>  COBJS	+= efikamx-usb.o
>  endif
> 
> -SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
> +SRCS	:= $(COBJS:.o=.c)
>  OBJS	:= $(addprefix $(obj),$(COBJS))
> -SOBJS	:= $(addprefix $(obj),$(SOBJS))
> 
> -$(LIB):	$(obj).depend $(OBJS) $(SOBJS)
> -	$(call cmd_link_o_target, $(OBJS) $(SOBJS))
> +$(LIB):	$(obj).depend $(OBJS)
> +	$(call cmd_link_o_target, $(OBJS))
> 
>  #########################################################################

Best regards,
Marek Vasut
Stefano Babic - June 12, 2012, 5:30 p.m.
On 29/05/2012 19:39, Fabio Estevam wrote:
> There is no .S file in this directory, so just remove SOBJS.
> 
> Cc: Jason Liu <r64343@freescale.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---


Applied the whole series to u-boot-imx, thanks.

Best regards,
Stefano Babic

Patch

diff --git a/board/freescale/mx53loco/Makefile b/board/freescale/mx53loco/Makefile
index a6ea939..8bc69a9 100644
--- a/board/freescale/mx53loco/Makefile
+++ b/board/freescale/mx53loco/Makefile
@@ -24,12 +24,11 @@  LIB	= $(obj)lib$(BOARD).o
 
 COBJS	:= mx53loco.o
 
-SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)
+SRCS	:= $(COBJS:.o=.c)
 OBJS	:= $(addprefix $(obj),$(COBJS))
-SOBJS	:= $(addprefix $(obj),$(SOBJS))
 
-$(LIB):	$(obj).depend $(OBJS) $(SOBJS)
-	$(call cmd_link_o_target, $(OBJS) $(SOBJS))
+$(LIB):	$(obj).depend $(OBJS)
+	$(call cmd_link_o_target, $(OBJS))
 
 #########################################################################