Patchwork lib: fwts_acpi_method: remove leading 0x in front of dumped strings

login
register
mail settings
Submitter Colin King
Date May 29, 2012, 1:28 p.m.
Message ID <1338298107-23485-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/161746/
State Accepted
Headers show

Comments

Colin King - May 29, 2012, 1:28 p.m.
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/lib/src/fwts_acpi_method.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Alex Hung - May 29, 2012, 2:27 p.m.
On 05/29/2012 09:28 PM, Colin King wrote:
> From: Colin Ian King<colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King<colin.king@canonical.com>
> ---
>   src/lib/src/fwts_acpi_method.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/src/fwts_acpi_method.c b/src/lib/src/fwts_acpi_method.c
> index 7a55ccd..5c2e3da 100644
> --- a/src/lib/src/fwts_acpi_method.c
> +++ b/src/lib/src/fwts_acpi_method.c
> @@ -199,7 +199,7 @@ static void fwts_method_dump_object_recursive(fwts_framework *fw, ACPI_OBJECT *o
>   			index_buf, (unsigned long long)obj->Integer.Value);
>   		break;
>   	case ACPI_TYPE_STRING:
> -		fwts_log_info_verbatum(fw, "%*s%sSTRING:  0x%s", depth * 2, "",
> +		fwts_log_info_verbatum(fw, "%*s%sSTRING:  %s", depth * 2, "",
>   			index_buf, obj->String.Pointer);
>   		break;
>   	case ACPI_TYPE_BUFFER:

Acked-by: Alex Hung <alex.hung@canonical.com>
Keng-Yu Lin - May 31, 2012, 6:58 a.m.
On Tue, May 29, 2012 at 9:28 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/src/fwts_acpi_method.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/src/fwts_acpi_method.c b/src/lib/src/fwts_acpi_method.c
> index 7a55ccd..5c2e3da 100644
> --- a/src/lib/src/fwts_acpi_method.c
> +++ b/src/lib/src/fwts_acpi_method.c
> @@ -199,7 +199,7 @@ static void fwts_method_dump_object_recursive(fwts_framework *fw, ACPI_OBJECT *o
>                        index_buf, (unsigned long long)obj->Integer.Value);
>                break;
>        case ACPI_TYPE_STRING:
> -               fwts_log_info_verbatum(fw, "%*s%sSTRING:  0x%s", depth * 2, "",
> +               fwts_log_info_verbatum(fw, "%*s%sSTRING:  %s", depth * 2, "",
>                        index_buf, obj->String.Pointer);
>                break;
>        case ACPI_TYPE_BUFFER:
> --
> 1.7.10
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - June 1, 2012, 3:41 a.m.
On 05/29/2012 09:28 PM, Colin King wrote:
> From: Colin Ian King<colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King<colin.king@canonical.com>
> ---
>   src/lib/src/fwts_acpi_method.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/src/fwts_acpi_method.c b/src/lib/src/fwts_acpi_method.c
> index 7a55ccd..5c2e3da 100644
> --- a/src/lib/src/fwts_acpi_method.c
> +++ b/src/lib/src/fwts_acpi_method.c
> @@ -199,7 +199,7 @@ static void fwts_method_dump_object_recursive(fwts_framework *fw, ACPI_OBJECT *o
>   			index_buf, (unsigned long long)obj->Integer.Value);
>   		break;
>   	case ACPI_TYPE_STRING:
> -		fwts_log_info_verbatum(fw, "%*s%sSTRING:  0x%s", depth * 2, "",
> +		fwts_log_info_verbatum(fw, "%*s%sSTRING:  %s", depth * 2, "",
>   			index_buf, obj->String.Pointer);
>   		break;
>   	case ACPI_TYPE_BUFFER:
Acked-by: Ivan Hu<ivan.hu@canonical.com>

Patch

diff --git a/src/lib/src/fwts_acpi_method.c b/src/lib/src/fwts_acpi_method.c
index 7a55ccd..5c2e3da 100644
--- a/src/lib/src/fwts_acpi_method.c
+++ b/src/lib/src/fwts_acpi_method.c
@@ -199,7 +199,7 @@  static void fwts_method_dump_object_recursive(fwts_framework *fw, ACPI_OBJECT *o
 			index_buf, (unsigned long long)obj->Integer.Value);
 		break;
 	case ACPI_TYPE_STRING:
-		fwts_log_info_verbatum(fw, "%*s%sSTRING:  0x%s", depth * 2, "",
+		fwts_log_info_verbatum(fw, "%*s%sSTRING:  %s", depth * 2, "",
 			index_buf, obj->String.Pointer);
 		break;
 	case ACPI_TYPE_BUFFER: