From patchwork Tue May 29 09:21:56 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanislaw Gruszka X-Patchwork-Id: 161726 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 218B8B6FBB for ; Tue, 29 May 2012 20:05:21 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753053Ab2E2KE6 (ORCPT ); Tue, 29 May 2012 06:04:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30294 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751501Ab2E2KE5 (ORCPT ); Tue, 29 May 2012 06:04:57 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4TA4tHJ025854 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 29 May 2012 06:04:55 -0400 Received: from localhost (dhcp-27-232.brq.redhat.com [10.34.27.232]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4T9LuRS018056; Tue, 29 May 2012 05:21:57 -0400 Date: Tue, 29 May 2012 11:21:56 +0200 From: Stanislaw Gruszka To: Bjorn Helgaas Cc: Kamil Grzebien , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: Initializing iwl3945 error Message-ID: <20120529092154.GA2441@redhat.com> References: <20120313081235.GC15333@redhat.com> <20120528140448.GA22783@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-12-10) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, May 28, 2012 at 12:21:34PM -0600, Bjorn Helgaas wrote: > linked in vs. loaded as a module after boot? What if you add a long > delay in the driver probe routine? I'm attaching patch which add 200 ms delay after pci_enable_device() in ->probe routine. Stanislaw diff --git a/drivers/net/wireless/iwlegacy/3945-mac.c b/drivers/net/wireless/iwlegacy/3945-mac.c index faec404..96fe43d 100644 --- a/drivers/net/wireless/iwlegacy/3945-mac.c +++ b/drivers/net/wireless/iwlegacy/3945-mac.c @@ -3635,6 +3635,8 @@ il3945_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) goto out_ieee80211_free_hw; } + msleep(200); + pci_set_master(pdev); err = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));