Patchwork [2/2] lib: fwts_framework: drop unneccessary \n in log call

login
register
mail settings
Submitter Colin King
Date May 28, 2012, 3:01 p.m.
Message ID <1338217284-8752-2-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/161626/
State Accepted
Headers show

Comments

Colin King - May 28, 2012, 3:01 p.m.
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/lib/src/fwts_framework.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Keng-Yu Lin - May 31, 2012, 6:54 a.m.
On Mon, May 28, 2012 at 11:01 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/src/fwts_framework.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c
> index 2b42982..9ff8c20 100644
> --- a/src/lib/src/fwts_framework.c
> +++ b/src/lib/src/fwts_framework.c
> @@ -876,7 +876,7 @@ static void fwts_framework_heading_info(fwts_framework *fw, fwts_list *tests_to_
>                        strcat(tests, test->name);
>                }
>
> -               fwts_log_info(fw, "Running tests: %s.\n",
> +               fwts_log_info(fw, "Running tests: %s.",
>                        fwts_list_len(tests_to_run) == 0 ? "None" : tests);
>                if (!(fw->flags & FWTS_FRAMEWORK_FLAGS_LP_TAGS))
>                        fwts_log_newline(fw->results);
> --
> 1.7.10
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - June 1, 2012, 2:43 a.m.
On 05/28/2012 11:01 PM, Colin King wrote:
> From: Colin Ian King<colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King<colin.king@canonical.com>
> ---
>   src/lib/src/fwts_framework.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c
> index 2b42982..9ff8c20 100644
> --- a/src/lib/src/fwts_framework.c
> +++ b/src/lib/src/fwts_framework.c
> @@ -876,7 +876,7 @@ static void fwts_framework_heading_info(fwts_framework *fw, fwts_list *tests_to_
>   			strcat(tests, test->name);
>   		}
>
> -		fwts_log_info(fw, "Running tests: %s.\n",
> +		fwts_log_info(fw, "Running tests: %s.",
>   			fwts_list_len(tests_to_run) == 0 ? "None" : tests);
>   		if (!(fw->flags&  FWTS_FRAMEWORK_FLAGS_LP_TAGS))
>   			fwts_log_newline(fw->results);
Acked-by: Ivan Hu<ivan.hu@canonical.com>

Patch

diff --git a/src/lib/src/fwts_framework.c b/src/lib/src/fwts_framework.c
index 2b42982..9ff8c20 100644
--- a/src/lib/src/fwts_framework.c
+++ b/src/lib/src/fwts_framework.c
@@ -876,7 +876,7 @@  static void fwts_framework_heading_info(fwts_framework *fw, fwts_list *tests_to_
 			strcat(tests, test->name);
 		}
 
-		fwts_log_info(fw, "Running tests: %s.\n",
+		fwts_log_info(fw, "Running tests: %s.",
 			fwts_list_len(tests_to_run) == 0 ? "None" : tests);
 		if (!(fw->flags & FWTS_FRAMEWORK_FLAGS_LP_TAGS))
 			fwts_log_newline(fw->results);