mbox

[PULL,1.1,0/6] target-xtensa MMU fixes

Message ID 1338129294-16742-1-git-send-email-jcmvbkbc@gmail.com
State New
Headers show

Pull-request

git://jcmvbkbc.spb.ru/dumb/qemu-xtensa.git xtensa

Message

Max Filippov May 27, 2012, 2:34 p.m. UTC
Hello.

This series fixes subtle bugs in the xtensa hardware pagewalking implementation
and adds more MMU test cases.

The following changes since commit aeb29b6459cb9496b38c820f3faff64cf2369d0d:

  audio: Always call fini on exit (2012-05-24 19:35:27 +0400)

are available in the git repository at:
  git://jcmvbkbc.spb.ru/dumb/qemu-xtensa.git xtensa

Max Filippov (6):
  target-xtensa: flush TLB page for new MMU mapping
  target-xtensa: update EXCVADDR in case of page table lookup
  target-xtensa: extract TLB entry setting method
  target-xtensa: update autorefill TLB entries conditionally
  target-xtensa: control page table lookup explicitly
  target-xtensa: add MMU pagewalking tests

 target-xtensa/cpu.h         |    5 +-
 target-xtensa/helper.c      |   61 +++++++-----
 target-xtensa/op_helper.c   |   20 +++-
 tests/tcg/xtensa/test_mmu.S |  221 ++++++++++++++++++++++++++++++++++++++++---
 4 files changed, 260 insertions(+), 47 deletions(-)

Comments

Andreas Färber May 27, 2012, 2:54 p.m. UTC | #1
Am 27.05.2012 16:34, schrieb Max Filippov:
> Hello.
> 
> This series fixes subtle bugs in the xtensa hardware pagewalking implementation
> and adds more MMU test cases.
> 
> The following changes since commit aeb29b6459cb9496b38c820f3faff64cf2369d0d:
> 
>   audio: Always call fini on exit (2012-05-24 19:35:27 +0400)
> 
> are available in the git repository at:
>   git://jcmvbkbc.spb.ru/dumb/qemu-xtensa.git xtensa
> 
> Max Filippov (6):
>   target-xtensa: flush TLB page for new MMU mapping

At least this patch seems to have never reached my inbox before. The
expected procedure is to first patches on the list, wait for review and
only after acks have been received or sufficient time passed and a ping
remained without acks, post a PULL request that can then be applied
without review of contents, only making sure it doesn't break the build
or significantly regresses the target(s).

This patch itself looks okay, but I'm pointing it out since the list
seems to be lagging once again and because you're sending it for the
final RC.

Regards,
Andreas

>   target-xtensa: update EXCVADDR in case of page table lookup
>   target-xtensa: extract TLB entry setting method
>   target-xtensa: update autorefill TLB entries conditionally
>   target-xtensa: control page table lookup explicitly
>   target-xtensa: add MMU pagewalking tests
> 
>  target-xtensa/cpu.h         |    5 +-
>  target-xtensa/helper.c      |   61 +++++++-----
>  target-xtensa/op_helper.c   |   20 +++-
>  tests/tcg/xtensa/test_mmu.S |  221 ++++++++++++++++++++++++++++++++++++++++---
>  4 files changed, 260 insertions(+), 47 deletions(-)
Max Filippov May 27, 2012, 3:27 p.m. UTC | #2
On Sun, May 27, 2012 at 6:54 PM, Andreas Färber <afaerber@suse.de> wrote:
> Am 27.05.2012 16:34, schrieb Max Filippov:
>> Hello.
>>
>> This series fixes subtle bugs in the xtensa hardware pagewalking implementation
>> and adds more MMU test cases.
>>
>> The following changes since commit aeb29b6459cb9496b38c820f3faff64cf2369d0d:
>>
>>   audio: Always call fini on exit (2012-05-24 19:35:27 +0400)
>>
>> are available in the git repository at:
>>   git://jcmvbkbc.spb.ru/dumb/qemu-xtensa.git xtensa
>>
>> Max Filippov (6):
>>   target-xtensa: flush TLB page for new MMU mapping
>
> At least this patch seems to have never reached my inbox before. The

My bad, actually I send it for the first time, should have been mere
patch series. Please review.

> expected procedure is to first patches on the list, wait for review and
> only after acks have been received or sufficient time passed and a ping
> remained without acks, post a PULL request that can then be applied
> without review of contents, only making sure it doesn't break the build
> or significantly regresses the target(s).
>
> This patch itself looks okay, but I'm pointing it out since the list
> seems to be lagging once again and because you're sending it for the
> final RC.
Blue Swirl June 9, 2012, 11:30 a.m. UTC | #3
Thanks, applied all.

On Sun, May 27, 2012 at 2:34 PM, Max Filippov <jcmvbkbc@gmail.com> wrote:
> Hello.
>
> This series fixes subtle bugs in the xtensa hardware pagewalking implementation
> and adds more MMU test cases.
>
> The following changes since commit aeb29b6459cb9496b38c820f3faff64cf2369d0d:
>
>  audio: Always call fini on exit (2012-05-24 19:35:27 +0400)
>
> are available in the git repository at:
>  git://jcmvbkbc.spb.ru/dumb/qemu-xtensa.git xtensa
>
> Max Filippov (6):
>  target-xtensa: flush TLB page for new MMU mapping
>  target-xtensa: update EXCVADDR in case of page table lookup
>  target-xtensa: extract TLB entry setting method
>  target-xtensa: update autorefill TLB entries conditionally
>  target-xtensa: control page table lookup explicitly
>  target-xtensa: add MMU pagewalking tests
>
>  target-xtensa/cpu.h         |    5 +-
>  target-xtensa/helper.c      |   61 +++++++-----
>  target-xtensa/op_helper.c   |   20 +++-
>  tests/tcg/xtensa/test_mmu.S |  221 ++++++++++++++++++++++++++++++++++++++++---
>  4 files changed, 260 insertions(+), 47 deletions(-)
>
> --
> 1.7.7.6