From patchwork Sat May 26 16:38:35 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiang Liu X-Patchwork-Id: 161494 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 78D4CB6F13 for ; Sun, 27 May 2012 02:40:00 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753252Ab2EZQix (ORCPT ); Sat, 26 May 2012 12:38:53 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:37910 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752713Ab2EZQiw (ORCPT ); Sat, 26 May 2012 12:38:52 -0400 Received: by pbbrp8 with SMTP id rp8so2974637pbb.19 for ; Sat, 26 May 2012 09:38:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=Jq5NVag8UrRMp1G4wl/acvXL1Lc0LlgyO9RTWL9g550=; b=GHsTyUggsg4xg8+7cI3KJ0ZedWy4alU51WPdVwKy51yT4phOD7PB+HDkSX2cgs2DF4 SdX9b2mXZ5MWzmAp7OlsWAJjdwoLt4htZ/OJCVYQm/sQhurSo//mqQkZyRkJsR1UfQ7k qYwerim3jvAdGYYdDM9WRNt2WK0Ay2Nw2SSG18YHf85LWcrsTu2daScAaoxR8uqF1V2w j6KYEqDMhhvZn/s+Y0/4Vg6kAMYI/Faf4w0YOIOj6l9i+cMHJtLq+g5v4513LPi3rS9j rfw4p9YQURQ3C1GyPX6AEhdmnXlI04mwzssGMWA7lpBjwvKXfx5i9zeZVyQP6bf0lX7b ip9Q== Received: by 10.68.203.73 with SMTP id ko9mr9719305pbc.66.1338050331510; Sat, 26 May 2012 09:38:51 -0700 (PDT) Received: from [192.168.0.104] ([221.221.26.240]) by mx.google.com with ESMTPS id tt5sm8829913pbc.12.2012.05.26.09.38.43 (version=SSLv3 cipher=OTHER); Sat, 26 May 2012 09:38:50 -0700 (PDT) Message-ID: <4FC1070B.2040403@gmail.com> Date: Sun, 27 May 2012 00:38:35 +0800 From: Jiang Liu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Taku Izumi CC: Dan Williams , Maciej Sosnowski , Vinod Koul , Keping Chen , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [RFC PATCH v2 0/7] dmaengine: enhance dmaengine to support DMA device hotplug References: <1337003229-9158-1-git-send-email-jiang.liu@huawei.com> <20120525094919.078fdff9.izumi.taku@jp.fujitsu.com> In-Reply-To: <20120525094919.078fdff9.izumi.taku@jp.fujitsu.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Taku, Sorry, forgot to export the percpu variable. Could you please help to test the patch below? Thanks! --- On 05/25/2012 08:49 AM, Taku Izumi wrote: > Hi Jiang, > > Build failed with "Device Drivers/DMA Engine Support/Async_tx: Offload > support for the async_tx api" enabled because of undefined symbol. > Patch 5/7 needs a fix? > > (snip) > CHK include/linux/version.h > CHK include/generated/utsrelease.h > CALL scripts/checksyscalls.sh > CHK include/generated/compile.h > CHK include/linux/version.h > make[2]: Nothing to be done for `all'. > Building modules, stage 2. > TEST posttest > MODPOST 2201 modules > Succeed: decoded and checked 1356146 instructions > TEST posttest > Success: decoded and checked 1000000 random instructions with 0 errors (seed:0x9432fb9e) > Kernel: arch/x86/boot/bzImage is ready (#13) > ERROR: "dmaengine_chan_ref_count" [crypto/async_tx/async_xor.ko] undefined! > ERROR: "dmaengine_chan_ref_count" [crypto/async_tx/async_raid6_recov.ko] undefined! > ERROR: "dmaengine_chan_ref_count" [crypto/async_tx/async_pq.ko] undefined! > ERROR: "dmaengine_chan_ref_count" [crypto/async_tx/async_memcpy.ko] undefined! > make[1]: *** [__modpost] Error 1 > make: *** [modules] Error 2 > > Best regards, > Taku Izumi > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/dma/dmaengine.c b/drivers/dma/dmaengine.c index 8a41bdf..26316f6 100644 --- a/drivers/dma/dmaengine.c +++ b/drivers/dma/dmaengine.c @@ -73,6 +73,7 @@ static atomic_t dmaengine_dirty; static struct static_key dmaengine_quiesce = STATIC_KEY_INIT_FALSE; static DECLARE_WAIT_QUEUE_HEAD(dmaengine_wait_queue); DEFINE_PER_CPU(long, dmaengine_chan_ref_count); +EXPORT_PER_CPU_SYMBOL(dmaengine_chan_ref_count); #endif /* CONFIG_DMA_ENGINE_HOTPLUG */ /* --- sysfs implementation --- */