Patchwork powerpc: remove the redundant _tlbil_pid at SMP case

login
register
mail settings
Submitter Dave Liu
Date Dec. 31, 2008, 9:42 a.m.
Message ID <1230716575-30786-1-git-send-email-daveliu@freescale.com>
Download mbox | patch
Permalink /patch/16133/
State Accepted
Commit d6a09e0cd6329db6f48b0015407a1b038d8fa64b
Delegated to: Benjamin Herrenschmidt
Headers show

Comments

Dave Liu - Dec. 31, 2008, 9:42 a.m.
Signed-off-by: Dave Liu <daveliu@freescale.com>
---
 arch/powerpc/mm/tlb_nohash.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Benjamin Herrenschmidt - Dec. 31, 2008, 11:05 a.m.
On Wed, 2008-12-31 at 17:42 +0800, Dave Liu wrote:
> Signed-off-by: Dave Liu <daveliu@freescale.com>
> ---
>  arch/powerpc/mm/tlb_nohash.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/powerpc/mm/tlb_nohash.c b/arch/powerpc/mm/tlb_nohash.c
> index 803a64c..39ac22b 100644
> --- a/arch/powerpc/mm/tlb_nohash.c
> +++ b/arch/powerpc/mm/tlb_nohash.c
> @@ -189,8 +189,9 @@ void flush_tlb_kernel_range(unsigned long start, unsigned long end)
>  	smp_call_function(do_flush_tlb_mm_ipi, NULL, 1);
>  	_tlbil_pid(0);
>  	preempt_enable();
> -#endif
> +#else
>  	_tlbil_pid(0);
> +#endif
>  }
>  EXPORT_SYMBOL(flush_tlb_kernel_range);

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---

Patch

diff --git a/arch/powerpc/mm/tlb_nohash.c b/arch/powerpc/mm/tlb_nohash.c
index 803a64c..39ac22b 100644
--- a/arch/powerpc/mm/tlb_nohash.c
+++ b/arch/powerpc/mm/tlb_nohash.c
@@ -189,8 +189,9 @@  void flush_tlb_kernel_range(unsigned long start, unsigned long end)
 	smp_call_function(do_flush_tlb_mm_ipi, NULL, 1);
 	_tlbil_pid(0);
 	preempt_enable();
-#endif
+#else
 	_tlbil_pid(0);
+#endif
 }
 EXPORT_SYMBOL(flush_tlb_kernel_range);