From patchwork Fri May 25 10:40:52 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 161285 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id 819FFB6EEB for ; Fri, 25 May 2012 20:41:04 +1000 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1SXrx9-0008Rn-BI for incoming@patchwork.ozlabs.org; Fri, 25 May 2012 10:41:03 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1SXrx4-0008R4-SW for fwts-devel@lists.ubuntu.com; Fri, 25 May 2012 10:40:58 +0000 Received: from cpc19-craw6-2-0-cust5.croy.cable.virginmedia.com ([77.102.228.6] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SXrx4-0005dB-Pn for fwts-devel@lists.ubuntu.com; Fri, 25 May 2012 10:40:58 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH 7/8] lib: fwts_oops.c: add more comments Date: Fri, 25 May 2012 11:40:52 +0100 Message-Id: <1337942453-30224-8-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.7.10 In-Reply-To: <1337942453-30224-1-git-send-email-colin.king@canonical.com> References: <1337942453-30224-1-git-send-email-colin.king@canonical.com> X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.13 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: fwts-devel-bounces@lists.ubuntu.com Errors-To: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King Signed-off-by: Colin Ian King Acked-by: Keng-Yu Lin Acked-by: Ivan Hu --- src/lib/src/fwts_oops.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/lib/src/fwts_oops.c b/src/lib/src/fwts_oops.c index 888bb46..df9c3c7 100644 --- a/src/lib/src/fwts_oops.c +++ b/src/lib/src/fwts_oops.c @@ -33,6 +33,12 @@ (FWTS_OOPS_GOT_OOPS | FWTS_OOPS_GOT_STACK | FWTS_OOPS_GOT_CALL_TRACE | FWTS_OOPS_GOT_END_TRACE) +/* + * fwts_oops_dump() + * for a given item in a kernel log list, scan for an oops message and + * if we find an oops message increment 'oopses' and dump out the oops + * message to the fwts log + */ void fwts_oops_dump(fwts_framework *fw, fwts_list_link *bug_item, int *oopses) { fwts_list_link *item = bug_item; @@ -82,6 +88,12 @@ void fwts_oops_dump(fwts_framework *fw, fwts_list_link *bug_item, int *oopses) } } +/* + * fwts_oos_check() + * scan kernel log list for any oops messages. The number of oops + * messages found is returned in 'oopses'. Oops messages are logged to the + * fwts log. + */ int fwts_oops_check(fwts_framework *fw, fwts_list *klog, int *oopses) { fwts_list_link *item;