Patchwork [7/8] lib: fwts_oops.c: add more comments

login
register
mail settings
Submitter Colin King
Date May 25, 2012, 10:40 a.m.
Message ID <1337942453-30224-8-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/161285/
State Accepted
Headers show

Comments

Colin King - May 25, 2012, 10:40 a.m.
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/lib/src/fwts_oops.c |   12 ++++++++++++
 1 file changed, 12 insertions(+)
Keng-Yu Lin - May 31, 2012, 6:51 a.m.
On Fri, May 25, 2012 at 6:40 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/lib/src/fwts_oops.c |   12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/src/lib/src/fwts_oops.c b/src/lib/src/fwts_oops.c
> index 888bb46..df9c3c7 100644
> --- a/src/lib/src/fwts_oops.c
> +++ b/src/lib/src/fwts_oops.c
> @@ -33,6 +33,12 @@
>        (FWTS_OOPS_GOT_OOPS | FWTS_OOPS_GOT_STACK | FWTS_OOPS_GOT_CALL_TRACE | FWTS_OOPS_GOT_END_TRACE)
>
>
> +/*
> + *  fwts_oops_dump()
> + *     for a given item in a kernel log list, scan for an oops message and
> + *     if we find an oops message increment 'oopses' and dump out the oops
> + *     message to the fwts log
> + */
>  void fwts_oops_dump(fwts_framework *fw, fwts_list_link *bug_item, int *oopses)
>  {
>        fwts_list_link *item = bug_item;
> @@ -82,6 +88,12 @@ void fwts_oops_dump(fwts_framework *fw, fwts_list_link *bug_item, int *oopses)
>        }
>  }
>
> +/*
> + *  fwts_oos_check()
> + *     scan kernel log list for any oops messages. The number of oops
> + *     messages found is returned in 'oopses'.  Oops messages are logged to the
> + *     fwts log.
> + */
>  int fwts_oops_check(fwts_framework *fw, fwts_list *klog, int *oopses)
>  {
>        fwts_list_link *item;
> --
> 1.7.10
>
Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - June 1, 2012, 1:42 a.m.
On 05/25/2012 06:40 PM, Colin King wrote:
> From: Colin Ian King<colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King<colin.king@canonical.com>
> ---
>   src/lib/src/fwts_oops.c |   12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/src/lib/src/fwts_oops.c b/src/lib/src/fwts_oops.c
> index 888bb46..df9c3c7 100644
> --- a/src/lib/src/fwts_oops.c
> +++ b/src/lib/src/fwts_oops.c
> @@ -33,6 +33,12 @@
>   	(FWTS_OOPS_GOT_OOPS | FWTS_OOPS_GOT_STACK | FWTS_OOPS_GOT_CALL_TRACE | FWTS_OOPS_GOT_END_TRACE)
>
>
> +/*
> + *  fwts_oops_dump()
> + *	for a given item in a kernel log list, scan for an oops message and
> + *	if we find an oops message increment 'oopses' and dump out the oops
> + *	message to the fwts log
> + */
>   void fwts_oops_dump(fwts_framework *fw, fwts_list_link *bug_item, int *oopses)
>   {
>   	fwts_list_link *item = bug_item;
> @@ -82,6 +88,12 @@ void fwts_oops_dump(fwts_framework *fw, fwts_list_link *bug_item, int *oopses)
>   	}
>   }
>
> +/*
> + *  fwts_oos_check()
> + *	scan kernel log list for any oops messages. The number of oops
> + *	messages found is returned in 'oopses'.  Oops messages are logged to the
> + *	fwts log.
> + */
>   int fwts_oops_check(fwts_framework *fw, fwts_list *klog, int *oopses)
>   {
>   	fwts_list_link *item;
Acked-by: Ivan Hu<ivan.hu@canonical.com>

Patch

diff --git a/src/lib/src/fwts_oops.c b/src/lib/src/fwts_oops.c
index 888bb46..df9c3c7 100644
--- a/src/lib/src/fwts_oops.c
+++ b/src/lib/src/fwts_oops.c
@@ -33,6 +33,12 @@ 
 	(FWTS_OOPS_GOT_OOPS | FWTS_OOPS_GOT_STACK | FWTS_OOPS_GOT_CALL_TRACE | FWTS_OOPS_GOT_END_TRACE)
 
 
+/*
+ *  fwts_oops_dump()
+ *	for a given item in a kernel log list, scan for an oops message and
+ *	if we find an oops message increment 'oopses' and dump out the oops
+ *	message to the fwts log
+ */
 void fwts_oops_dump(fwts_framework *fw, fwts_list_link *bug_item, int *oopses)
 {
 	fwts_list_link *item = bug_item;
@@ -82,6 +88,12 @@  void fwts_oops_dump(fwts_framework *fw, fwts_list_link *bug_item, int *oopses)
 	}
 }
 
+/*
+ *  fwts_oos_check()
+ *	scan kernel log list for any oops messages. The number of oops
+ *	messages found is returned in 'oopses'.  Oops messages are logged to the
+ *	fwts log.
+ */
 int fwts_oops_check(fwts_framework *fw, fwts_list *klog, int *oopses)
 {
 	fwts_list_link *item;