Patchwork [1/2] can: Added constants containing length of CAN identifiers

login
register
mail settings
Submitter Rostislav Lisovy
Date May 25, 2012, 9:12 a.m.
Message ID <1337937157-7680-1-git-send-email-lisovy@gmail.com>
Download mbox | patch
Permalink /patch/161260/
State Deferred
Delegated to: David Miller
Headers show

Comments

Rostislav Lisovy - May 25, 2012, 9:12 a.m.
The necessary information might be determined out of the CAN_*_MASK,
however it is undesirable to misuse masks for such purpose.

Signed-off-by: Rostislav Lisovy <lisovy@gmail.com>
---
 include/linux/can.h |    3 +++
 1 file changed, 3 insertions(+)
David Miller - May 25, 2012, 9:22 a.m.
It is not appropriate to submit new features at this time,
as I described in detail in:

http://marc.info/?l=netfilter-devel&m=133763475402372&w=2

I used a subject line with BIG CAPITAL LETTERS in that posting so
there is really no reason you should have overlooked it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rostislav Lisovy - May 25, 2012, 10:44 a.m.
On Fri, 2012-05-25 at 05:22 -0400, David Miller wrote: 
> It is not appropriate to submit new features at this time,
> as I described in detail in:
> 
> http://marc.info/?l=netfilter-devel&m=133763475402372&w=2
> 
> I used a subject line with BIG CAPITAL LETTERS in that posting so
> there is really no reason you should have overlooked it.


I am very sorry for not going through the mailing list history
thoroughly enough and thus overlooking your announcement. This was
however meant more like a [RFC]. If anybody has any comments, please
send them to me.
I will resend the patches as soon as the net-next is open.

Best regards,
Rostislav Lisovy

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/include/linux/can.h b/include/linux/can.h
index 9a19bcb..08d1610 100644
--- a/include/linux/can.h
+++ b/include/linux/can.h
@@ -38,6 +38,9 @@ 
  */
 typedef __u32 canid_t;
 
+#define CAN_SFF_ID_BITS		11
+#define CAN_EFF_ID_BITS		29
+
 /*
  * Controller Area Network Error Frame Mask structure
  *