Patchwork Precise SRU, [PATCH 0/12] CONFIG_DSA=m, 12 patches

login
register
mail settings
Submitter Tim Gardner
Date May 24, 2012, 9:05 p.m.
Message ID <4FBEA28A.2080007@canonical.com>
Download mbox
Permalink /patch/161216/
State New
Headers show

Pull-request

git://kernel.ubuntu.com/rtg/ubuntu-precise.git dsa

Comments

Tim Gardner - May 24, 2012, 9:05 p.m.
Sometimes I hate git send-email.

http://bugs.launchpad.net/bugs/1004148

The DSA transport is experimental. By policy it should not be built-in. 
The dependent hardware modules in drivers/net/dsa will load the 
transport as a result of udev probing. Finally, this is pretty esoteric 
and rare hardware, so is unlikely to cause any issues with a normal 
desktop or server.

rtg
Seth Forshee - May 24, 2012, 9:31 p.m.
On Thu, May 24, 2012 at 03:05:14PM -0600, Tim Gardner wrote:
> Sometimes I hate git send-email.
> 
> http://bugs.launchpad.net/bugs/1004148
> 
> The DSA transport is experimental. By policy it should not be
> built-in. The dependent hardware modules in drivers/net/dsa will
> load the transport as a result of udev probing. Finally, this is
> pretty esoteric and rare hardware, so is unlikely to cause any
> issues with a normal desktop or server.

Seems like the only real risk of regression outside of the driver itself
would be build problems, but I'm assuming you've already tested for
those. It's definitely better to have experimental code in a module, so
this seems worthwhile.

Acked-by: Seth Forshee <seth.forshee@canonical.com>
Herton Ronaldo Krzesinski - May 25, 2012, 2:45 a.m.
On Thu, May 24, 2012 at 03:05:14PM -0600, Tim Gardner wrote:
> Sometimes I hate git send-email.
> 
> http://bugs.launchpad.net/bugs/1004148
> 
> The DSA transport is experimental. By policy it should not be
> built-in. The dependent hardware modules in drivers/net/dsa will
> load the transport as a result of udev probing. Finally, this is
> pretty esoteric and rare hardware, so is unlikely to cause any
> issues with a normal desktop or server.

Seems there were a lot of shuffling in configs because of highbank where
CONFIG_PHYLIB turned to m. Perhaps it could be turned to y (if possible
and makes sense) as well to avoid other configs growing, but that is
just an observation. Ack on the patches.

> 
> rtg
> -- 
> Tim Gardner tim.gardner@canonical.com

> The following changes since commit f9c4c36805ef1e62ccfd3fbc4540ec2c36189bd5:
> 
>   UBUNTU: Ubuntu-3.2.0-25.40 (2012-05-23 18:04:06 +0100)
> 
> are available in the git repository at:
> 
>   git://kernel.ubuntu.com/rtg/ubuntu-precise.git dsa
> 
> for you to fetch changes up to 5e469dd71d74c3b0b2276ec1f44e4e900f1eac24:
> 
>   UBUNTU: [Config] CONFIG_NET_DSA=m (2012-05-24 14:49:07 -0600)
> 
> ----------------------------------------------------------------
> Ben Hutchings (9):
>       dsa: Change dsa_uses_{dsa, trailer}_tags() into inline functions
>       dsa: Export functions from core to modules
>       dsa: Combine core and tagging code
>       mv88e6xxx: Combine mv88e6131 and mv88e612_61_65 drivers
>       dsa: Define module author, description, license and aliases for drivers
>       dsa: Allow core and drivers to be built as modules
>       dsa: Remove unnecessary exports
>       dsa: Move all definitions needed by drivers into <net/dsa.h>
>       dsa: Move switch drivers to new directory drivers/net/dsa
> 
> Chris Healy (1):
>       dsa: Add reporting of silicon revision for Marvell 88E6123/88E6161/88E6165 switches.
> 
> Paul Gortmaker (1):
>       drivers/net: dsa/mv88e6xxx.c files need linux/module.h
> 
> Tim Gardner (1):
>       UBUNTU: [Config] CONFIG_NET_DSA=m
> 
>  debian.master/config/amd64/config.common.amd64     |   13 +-
>  debian.master/config/armel/config.common.armel     |   14 +-
>  debian.master/config/armhf/config.common.armhf     |    1 -
>  debian.master/config/armhf/config.flavour.highbank |   17 ++-
>  debian.master/config/armhf/config.flavour.omap     |   15 +-
>  debian.master/config/config.common.ubuntu          |   22 +--
>  debian.master/config/i386/config.common.i386       |   14 +-
>  debian.master/config/powerpc/config.common.powerpc |   14 +-
>  debian.master/config/ppc64/config.common.ppc64     |   14 +-
>  drivers/net/Kconfig                                |    2 +
>  drivers/net/Makefile                               |    1 +
>  drivers/net/dsa/Kconfig                            |   36 +++++
>  drivers/net/dsa/Makefile                           |    9 ++
>  {net => drivers/net}/dsa/mv88e6060.c               |    8 +-
>  {net => drivers/net}/dsa/mv88e6123_61_65.c         |   41 +++---
>  {net => drivers/net}/dsa/mv88e6131.c               |   21 +--
>  {net => drivers/net}/dsa/mv88e6xxx.c               |   30 +++-
>  {net => drivers/net}/dsa/mv88e6xxx.h               |    3 +
>  include/linux/netdevice.h                          |    4 +-
>  include/net/dsa.h                                  |  143 +++++++++++++++++++-
>  net/dsa/Kconfig                                    |   38 +-----
>  net/dsa/Makefile                                   |   19 +--
>  net/dsa/dsa.c                                      |   51 +++----
>  net/dsa/dsa_priv.h                                 |  127 +----------------
>  net/dsa/tag_dsa.c                                  |   15 +-
>  net/dsa/tag_edsa.c                                 |   15 +-
>  net/dsa/tag_trailer.c                              |   15 +-
>  27 files changed, 400 insertions(+), 302 deletions(-)
>  create mode 100644 drivers/net/dsa/Kconfig
>  create mode 100644 drivers/net/dsa/Makefile
>  rename {net => drivers/net}/dsa/mv88e6060.c (96%)
>  rename {net => drivers/net}/dsa/mv88e6123_61_65.c (94%)
>  rename {net => drivers/net}/dsa/mv88e6131.c (96%)
>  rename {net => drivers/net}/dsa/mv88e6xxx.c (93%)
>  rename {net => drivers/net}/dsa/mv88e6xxx.h (95%)

> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team