Patchwork debugfs: fix strtoblk for 64bit block numbers

login
register
mail settings
Submitter Eric Sandeen
Date May 23, 2012, 11:01 p.m.
Message ID <4FBD6C3A.1020301@redhat.com>
Download mbox | patch
Permalink /patch/161047/
State Accepted
Headers show

Comments

Eric Sandeen - May 23, 2012, 11:01 p.m.
# debugfs -R "icheck 4295032832" testimage
debugfs 1.42.3 (14-May-2012)
got block 4295032832 for 4295032832
got block 65536 for 4295032832
Block	Inode number
65536	<block not found>

Um, that's no good.

Affects icheck, freeb, setb, testb...

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---


--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Theodore Ts'o - May 28, 2012, 2:12 a.m.
On Wed, May 23, 2012 at 06:01:14PM -0500, Eric Sandeen wrote:
> # debugfs -R "icheck 4295032832" testimage
> debugfs 1.42.3 (14-May-2012)
> got block 4295032832 for 4295032832
> got block 65536 for 4295032832
> Block	Inode number
> 65536	<block not found>
> 
> Um, that's no good.
> 
> Affects icheck, freeb, setb, testb...
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Thanks, applied.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/debugfs/util.c b/debugfs/util.c
index f43b470..b07a8cc 100644
--- a/debugfs/util.c
+++ b/debugfs/util.c
@@ -298,7 +298,7 @@  unsigned long long parse_ulonglong(const char *str, const char *cmd,
  */
 int strtoblk(const char *cmd, const char *str, blk64_t *ret)
 {
-	blk_t	blk;
+	blk64_t	blk;
 	int	err;
 
 	blk = parse_ulonglong(str, cmd, "block number", &err);