Patchwork [U-Boot] undefined reference to `net_set_upd_handler'

login
register
mail settings
Submitter Stephan Linz
Date May 23, 2012, 10:46 p.m.
Message ID <1337813209.14666.17.camel@keto>
Download mbox | patch
Permalink /patch/161046/
State Not Applicable
Headers show

Comments

Stephan Linz - May 23, 2012, 10:46 p.m.
Hello Joe,

just I've tried out your custodian network tree at a99acb7 and run in
the link error below:

net/libnet.o: In function `NetLoop':
net/net.c:539: undefined reference to `net_set_upd_handler'

I think it is a typo in commit 6476b33, or not?

The patch snipped below would fix it. It works to me.






br,
Stephan
Joe Hershberger - May 23, 2012, 10:50 p.m.
Hi Stephan,

On Wed, May 23, 2012 at 5:46 PM, Stephan Linz <linz@li-pro.net> wrote:
> Hello Joe,
>
> just I've tried out your custodian network tree at a99acb7 and run in
> the link error below:
>
> net/libnet.o: In function `NetLoop':
> net/net.c:539: undefined reference to `net_set_upd_handler'
>
> I think it is a typo in commit 6476b33, or not?

Thanks for trying it out.  It seems I typo'd that in a feature that is
not enabled on anything but microblaze.

Thanks for catching it.
-Joe
Joe Hershberger - May 23, 2012, 10:54 p.m.
Hi Stephan,

On Wed, May 23, 2012 at 5:50 PM, Joe Hershberger
<joe.hershberger@gmail.com> wrote:
> Hi Stephan,
>
> On Wed, May 23, 2012 at 5:46 PM, Stephan Linz <linz@li-pro.net> wrote:
>> Hello Joe,
>>
>> just I've tried out your custodian network tree at a99acb7 and run in
>> the link error below:
>>
>> net/libnet.o: In function `NetLoop':
>> net/net.c:539: undefined reference to `net_set_upd_handler'
>>
>> I think it is a typo in commit 6476b33, or not?

I've pushed a fixed version.

-Joe
Stephan Linz - May 23, 2012, 11:20 p.m.
Hi Joe,

thanks, now it compiles without error, tftpput works too.

br,
Stephan

Am Mittwoch, den 23.05.2012, 17:54 -0500 schrieb Joe Hershberger: 
> Hi Stephan,
> 
> On Wed, May 23, 2012 at 5:50 PM, Joe Hershberger
> <joe.hershberger@gmail.com> wrote:
> > Hi Stephan,
> >
> > On Wed, May 23, 2012 at 5:46 PM, Stephan Linz <linz@li-pro.net> wrote:
> >> Hello Joe,
> >>
> >> just I've tried out your custodian network tree at a99acb7 and run in
> >> the link error below:
> >>
> >> net/libnet.o: In function `NetLoop':
> >> net/net.c:539: undefined reference to `net_set_upd_handler'
> >>
> >> I think it is a typo in commit 6476b33, or not?
> 
> I've pushed a fixed version.
> 
> -Joe
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

Patch

diff --git a/net/net.c b/net/net.c
index 159b91a..9de7d92 100644
--- a/net/net.c
+++ b/net/net.c
@@ -536,7 +536,7 @@  restart:
done:
#ifdef CONFIG_CMD_TFTPPUT
        /* Clear out the handlers */
-       net_set_upd_handler(NULL);
+       net_set_udp_handler(NULL);
        net_set_icmp_handler(NULL);
#endif
        return ret;