Patchwork [U-Boot,1/2] patman: Change the location of patman config file

login
register
mail settings
Submitter Vikram Narayanan
Date May 23, 2012, 6:58 p.m.
Message ID <4FBD3372.9090904@gmail.com>
Download mbox | patch
Permalink /patch/161023/
State Accepted
Commit 2b36c75d7b930a860ec17f2af3321faa5811593b
Delegated to: Wolfgang Denk
Headers show

Comments

Vikram Narayanan - May 23, 2012, 6:58 p.m.
Move the config file from ~/.config/patman to ~/.patman as it is
more appropriate to have it there. Update the same in the README.

Signed-off-by: Vikram Narayanan <vikram186@gmail.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Wolfgang Denk <wd@denx.de> 
---
 tools/patman/README      |    2 +-
 tools/patman/settings.py |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Simon Glass - May 30, 2012, 5:34 a.m.
On Wed, May 23, 2012 at 11:58 AM, Vikram Narayanan <vikram186@gmail.com>wrote:

> Move the config file from ~/.config/patman to ~/.patman as it is
> more appropriate to have it there. Update the same in the README.
>
> Signed-off-by: Vikram Narayanan <vikram186@gmail.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Wolfgang Denk <wd@denx.de>
>

Acked-by: Simon Glass <sjg@chromium.org>


> ---
>  tools/patman/README      |    2 +-
>  tools/patman/settings.py |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/patman/README b/tools/patman/README
> index 7ba9e80..1af8665 100644
> --- a/tools/patman/README
> +++ b/tools/patman/README
> @@ -68,7 +68,7 @@ How to configure it
>  For most cases patman will locate and use the file 'doc/git-mailrc' in
>  your U-Boot directory. This contains most of the aliases you will need.
>
> -To add your own, create a file ~/.config/patman directory like this:
> +To add your own, create a file ~/.patman like this:
>
>  >>>>
>  # patman alias file
> diff --git a/tools/patman/settings.py b/tools/patman/settings.py
> index 049c709..f980071 100644
> --- a/tools/patman/settings.py
> +++ b/tools/patman/settings.py
> @@ -69,7 +69,7 @@ def Setup(config_fname=''):
>     """
>     settings = ConfigParser.SafeConfigParser()
>     if config_fname == '':
> -        config_fname = '%s/.config/patman' % os.getenv('HOME')
> +        config_fname = '%s/.patman' % os.getenv('HOME')
>     if config_fname:
>         settings.read(config_fname)
>
> --
> 1.7.4.1
>
>
>
Vikram Narayanan - June 13, 2012, 4:29 p.m.
Hello Wolfgang,

On 5/30/2012 11:04 AM, Simon Glass wrote:
>
>
> On Wed, May 23, 2012 at 11:58 AM, Vikram Narayanan <vikram186@gmail.com
> <mailto:vikram186@gmail.com>> wrote:
>
>     Move the config file from ~/.config/patman to ~/.patman as it is
>     more appropriate to have it there. Update the same in the README.
>
>     Signed-off-by: Vikram Narayanan <vikram186@gmail.com
>     <mailto:vikram186@gmail.com>>
>     Cc: Simon Glass <sjg@chromium.org <mailto:sjg@chromium.org>>
>     Cc: Wolfgang Denk <wd@denx.de <mailto:wd@denx.de>>
>
>
> Acked-by: Simon Glass <sjg@chromium.org <mailto:sjg@chromium.org>>

Can you please consider this patch series? Both are acked by Simon.
If you have any issues in taking this in, please let me know.

Thanks,
Vikram


>     ---
>       tools/patman/README      |    2 +-
>       tools/patman/settings.py |    2 +-
>       2 files changed, 2 insertions(+), 2 deletions(-)
>
>     diff --git a/tools/patman/README b/tools/patman/README
>     index 7ba9e80..1af8665 100644
>     --- a/tools/patman/README
>     +++ b/tools/patman/README
>     @@ -68,7 +68,7 @@ How to configure it
>       For most cases patman will locate and use the file 'doc/git-mailrc' in
>       your U-Boot directory. This contains most of the aliases you will
>     need.
>
>     -To add your own, create a file ~/.config/patman directory like this:
>     +To add your own, create a file ~/.patman like this:
>
>      >>>>
>       # patman alias file
>     diff --git a/tools/patman/settings.py b/tools/patman/settings.py
>     index 049c709..f980071 100644
>     --- a/tools/patman/settings.py
>     +++ b/tools/patman/settings.py
>     @@ -69,7 +69,7 @@ def Setup(config_fname=''):
>     """
>          settings = ConfigParser.SafeConfigParser()
>          if config_fname == '':
>     -        config_fname = '%s/.config/patman' % os.getenv('HOME')
>     +        config_fname = '%s/.patman' % os.getenv('HOME')
>          if config_fname:
>              settings.read(config_fname)
>
>     --
>     1.7.4.1
>
>
>
Wolfgang Denk - June 19, 2012, 8:51 p.m.
Dear Vikram Narayanan,

In message <4FBD3372.9090904@gmail.com> you wrote:
> Move the config file from ~/.config/patman to ~/.patman as it is
> more appropriate to have it there. Update the same in the README.
> 
> Signed-off-by: Vikram Narayanan <vikram186@gmail.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Wolfgang Denk <wd@denx.de> 
> ---
>  tools/patman/README      |    2 +-
>  tools/patman/settings.py |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/tools/patman/README b/tools/patman/README
index 7ba9e80..1af8665 100644
--- a/tools/patman/README
+++ b/tools/patman/README
@@ -68,7 +68,7 @@  How to configure it
 For most cases patman will locate and use the file 'doc/git-mailrc' in
 your U-Boot directory. This contains most of the aliases you will need.
 
-To add your own, create a file ~/.config/patman directory like this:
+To add your own, create a file ~/.patman like this:
 
 >>>>
 # patman alias file
diff --git a/tools/patman/settings.py b/tools/patman/settings.py
index 049c709..f980071 100644
--- a/tools/patman/settings.py
+++ b/tools/patman/settings.py
@@ -69,7 +69,7 @@  def Setup(config_fname=''):
     """
     settings = ConfigParser.SafeConfigParser()
     if config_fname == '':
-        config_fname = '%s/.config/patman' % os.getenv('HOME')
+        config_fname = '%s/.patman' % os.getenv('HOME')
     if config_fname:
         settings.read(config_fname)