From patchwork Wed May 23 15:27:07 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sosnowski, Maciej" X-Patchwork-Id: 160934 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 243D8B6FBB for ; Thu, 24 May 2012 01:08:33 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933502Ab2EWPIb (ORCPT ); Wed, 23 May 2012 11:08:31 -0400 Received: from mga14.intel.com ([143.182.124.37]:44721 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932304Ab2EWPIa (ORCPT ); Wed, 23 May 2012 11:08:30 -0400 Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga102.ch.intel.com with ESMTP; 23 May 2012 08:08:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="146790568" Received: from gklab-62-232.igk.intel.com (HELO linux.site) ([172.28.62.232]) by azsmga001.ch.intel.com with ESMTP; 23 May 2012 08:08:28 -0700 From: Maciej Sosnowski Subject: [PATCH] dca: check against empty dca_domains list before unregister provider To: dan.j.williams@intel.com Cc: jiang.liu@huawei.com, chenkeping@huawei.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org Date: Wed, 23 May 2012 17:27:07 +0200 Message-ID: <20120523152707.31683.81714.stgit@linux.site> User-Agent: StGIT/0.13 MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org When providers get blocked unregister_dca_providers() is called ending up with dca_providers and dca_domain lists emptied. Dca should be prevented from trying to unregister any provider if dca_domain list is found empty. Reported-by: Jiang Liu Tested-by: Gaohuai Han Signed-off-by: Maciej Sosnowski --- drivers/dca/dca-core.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/dca/dca-core.c b/drivers/dca/dca-core.c index bc6f5fa..819dfda 100644 --- a/drivers/dca/dca-core.c +++ b/drivers/dca/dca-core.c @@ -420,6 +420,11 @@ void unregister_dca_provider(struct dca_ raw_spin_lock_irqsave(&dca_lock, flags); + if (list_empty(&dca_domains)) { + raw_spin_unlock_irqrestore(&dca_lock, flags); + return; + } + list_del(&dca->node); pci_rc = dca_pci_rc_from_dev(dev);