Patchwork Add AC_ARG_ENABLE for libstdc++-v3

login
register
mail settings
Submitter rbmj
Date May 22, 2012, 8:37 p.m.
Message ID <4FBBF8F0.2000803@verizon.net>
Download mbox | patch
Permalink /patch/160737/
State New
Headers show

Comments

rbmj - May 22, 2012, 8:37 p.m.
This patch adds an AC_ARG_ENABLE option to build/not build 
libstdc++-v3.  I wrote the patch in order to allow the user to override 
the automatic disable for libstdc++-v3 for certain targets.

Patch is against configure.ac in trunk.

Robert Mason
rbmj - June 4, 2012, 7:35 p.m.
On 05/22/2012 04:37 PM, rbmj wrote:
> This patch adds an AC_ARG_ENABLE option to build/not build 
> libstdc++-v3.  I wrote the patch in order to allow the user to 
> override the automatic disable for libstdc++-v3 for certain targets.

Hi all,

What are the barriers to getting this in?  I wrote this so I don't have 
to continuously patch the configure script, and instead can override it 
with a command line option for my build targeting powerpc-wrs-vxworks.  
Even though VxWorks has it's own libstdc++, that doesn't mean that one 
wouldn't want to build it in order to get a more recent version than 
stock.  If it needs to be documented if someone can point me to the 
proper spot I can do that as well.

Thanks,

Robert Mason
Paolo Carlini - June 4, 2012, 8:32 p.m.
On 06/04/2012 09:35 PM, rbmj wrote:
> On 05/22/2012 04:37 PM, rbmj wrote:
>> This patch adds an AC_ARG_ENABLE option to build/not build 
>> libstdc++-v3.  I wrote the patch in order to allow the user to 
>> override the automatic disable for libstdc++-v3 for certain targets.
>
> Hi all,
>
> What are the barriers to getting this in?
Remember that all the libstdc++-v3 patches should also go to 
libstdc++@gcc.gnu.org.

Thanks,
Paolo.
rbmj - June 5, 2012, 12:40 a.m.
On 06/04/2012 04:32 PM, Paolo Carlini wrote:
> Remember that all the libstdc++-v3 patches should also go to
> libstdc++@gcc.gnu.org.
This isn't really a libstdc++ patch - it's actually a patch against 
top-level configure.ac that doesn't touch the libstdc++-v3 subdirectory. 
  But if I should still cross post it, I can.  I'm just not sure whether 
it counts as a "libstdc++-v3 patch".

Robert Mason
rbmj - June 11, 2012, 11:59 a.m.
On 05/22/2012 04:37 PM, rbmj wrote:
> This patch adds an AC_ARG_ENABLE option to build/not build 
> libstdc++-v3.  I wrote the patch in order to allow the user to 
> override the automatic disable for libstdc++-v3 for certain targets.
Ping^2 on http://gcc.gnu.org/ml/gcc-patches/2012-05/msg01525.html

Robert Mason
Paolo Bonzini - June 11, 2012, 12:02 p.m.
Il 11/06/2012 13:59, rbmj ha scritto:
> On 05/22/2012 04:37 PM, rbmj wrote:
>> This patch adds an AC_ARG_ENABLE option to build/not build
>> libstdc++-v3.  I wrote the patch in order to allow the user to
>> override the automatic disable for libstdc++-v3 for certain targets.
> Ping^2 on http://gcc.gnu.org/ml/gcc-patches/2012-05/msg01525.html

Ok.

Paolo
rbmj - June 11, 2012, 7:05 p.m.
On 06/11/2012 08:02 AM, Paolo Bonzini wrote:
> Il 11/06/2012 13:59, rbmj ha scritto:
>> On 05/22/2012 04:37 PM, rbmj wrote:
>>> This patch adds an AC_ARG_ENABLE option to build/not build
>>> libstdc++-v3.  I wrote the patch in order to allow the user to
>>> override the automatic disable for libstdc++-v3 for certain targets.
>> Ping^2 on http://gcc.gnu.org/ml/gcc-patches/2012-05/msg01525.html
> Ok.
>
If it's OK, could somebody please commit?  Thanks,

Robert
rbmj - June 21, 2012, 9:02 p.m.
On 06/11/2012 03:05 PM, rbmj wrote:
> On 06/11/2012 08:02 AM, Paolo Bonzini wrote:
>> Il 11/06/2012 13:59, rbmj ha scritto:
>>> On 05/22/2012 04:37 PM, rbmj wrote:
>>>> This patch adds an AC_ARG_ENABLE option to build/not build
>>>> libstdc++-v3.  I wrote the patch in order to allow the user to
>>>> override the automatic disable for libstdc++-v3 for certain targets.
>>> Ping^2 on http://gcc.gnu.org/ml/gcc-patches/2012-05/msg01525.html
>> Ok.
>>
> If it's OK, could somebody please commit?

Ping^3 - It's approved, but I don't have commit access, so could 
somebody please commit this for me?  It should be trivial, just apply 
the patch and run autoconf2.64 in top-level.  Thanks,

Robert Mason

Patch

From 69c085f3742e94501f4a202d1321e143afe9a115 Mon Sep 17 00:00:00 2001
From: rbmj <rbmj@verizon.net>
Date: Tue, 22 May 2012 16:32:02 -0400
Subject: [PATCH] Added --enable-libstdc++-v3 option.

---
 configure.ac |   38 +++++++++++++++++++++++++-------------
 1 files changed, 25 insertions(+), 13 deletions(-)

diff --git a/configure.ac b/configure.ac
index 378e9f5..c06b400 100644
--- a/configure.ac
+++ b/configure.ac
@@ -425,6 +425,15 @@  AC_ARG_ENABLE(libssp,
 ENABLE_LIBSSP=$enableval,
 ENABLE_LIBSSP=yes)
 
+AC_ARG_ENABLE(libstdc++-v3,
+AS_HELP_STRING([--disable-libstdc++-v3],
+  [do not build libstdc++-v3 directory]),
+ENABLE_LIBSTDCXX=$enableval,
+ENABLE_LIBSTDCXX=default)
+if test "${ENABLE_LIBSTDCXX}" = "no" ; then
+  noconfigdirs="$noconfigdirs libstdc++-v3"
+fi
+
 # Save it here so that, even in case of --enable-libgcj, if the Java
 # front-end isn't enabled, we still get libgcj disabled.
 libgcj_saved=$libgcj
@@ -544,19 +553,22 @@  case "${target}" in
 esac
 
 # Disable libstdc++-v3 for some systems.
-case "${target}" in
-  *-*-vxworks*)
-    # VxWorks uses the Dinkumware C++ library.
-    noconfigdirs="$noconfigdirs target-libstdc++-v3"
-    ;;
-  arm*-wince-pe*)
-    # the C++ libraries don't build on top of CE's C libraries
-    noconfigdirs="$noconfigdirs target-libstdc++-v3"
-    ;;
-  avr-*-*)
-    noconfigdirs="$noconfigdirs target-libstdc++-v3"
-    ;;
-esac
+# Allow user to override this if they pass --enable-libstdc++-v3
+if test "${ENABLE_LIBSTDCXX}" = "default" ; then
+  case "${target}" in
+    *-*-vxworks*)
+      # VxWorks uses the Dinkumware C++ library.
+      noconfigdirs="$noconfigdirs target-libstdc++-v3"
+      ;;
+    arm*-wince-pe*)
+      # the C++ libraries don't build on top of CE's C libraries
+      noconfigdirs="$noconfigdirs target-libstdc++-v3"
+      ;;
+    avr-*-*)
+      noconfigdirs="$noconfigdirs target-libstdc++-v3"
+      ;;
+  esac
+fi
 
 # Disable Fortran for some systems.
 case "${target}" in
-- 
1.7.5.4