Patchwork libquota: add a quotactl prototype

login
register
mail settings
Submitter Mike Frysinger
Date May 22, 2012, 7:41 p.m.
Message ID <1337715689-7116-1-git-send-email-vapier@gentoo.org>
Download mbox | patch
Permalink /patch/160726/
State Accepted
Headers show

Comments

Mike Frysinger - May 22, 2012, 7:41 p.m.
The commit 0df8a27bbaf51b55c0e8c3a533ef4c2ff9d79c9f removed the system
quota.h include, but in doing so, added the problem:
mkquota.c:55:2: warning: implicit declaration of function 'quotactl'

Since we're maintaining a copy of quota.h, add a proper func prototype.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 lib/quota/quota.h |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
Theodore Ts'o - May 28, 2012, 2:20 p.m.
On Tue, May 22, 2012 at 09:41:29AM -0000, Mike Frysinger wrote:
> The commit 0df8a27bbaf51b55c0e8c3a533ef4c2ff9d79c9f removed the system
> quota.h include, but in doing so, added the problem:
> mkquota.c:55:2: warning: implicit declaration of function 'quotactl'
> 
> Since we're maintaining a copy of quota.h, add a proper func prototype.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

Thanks, applied.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Andreas Dilger - May 28, 2012, 3:31 p.m.
On 2012-05-28, at 8:20, Ted Ts'o <tytso@mit.edu> wrote:

> On Tue, May 22, 2012 at 09:41:29AM -0000, Mike Frysinger wrote:
>> The commit 0df8a27bbaf51b55c0e8c3a533ef4c2ff9d79c9f removed the system
>> quota.h include, but in doing so, added the problem:
>> mkquota.c:55:2: warning: implicit declaration of function 'quotactl'
>> 
>> Since we're maintaining a copy of quota.h, add a proper func prototype.
>> 
>> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> 
> Thanks, applied.

This patch caused a compile failure on my FC 13 system, when I had no problem before, because caddr_t was not defined...

Cheers, Andreas--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mike Frysinger - May 29, 2012, 12:37 a.m.
On Monday 28 May 2012 11:31:42 Andreas Dilger wrote:
> On 2012-05-28, at 8:20, Ted Ts'o <tytso@mit.edu> wrote:
> > On Tue, May 22, 2012 at 09:41:29AM -0000, Mike Frysinger wrote:
> >> The commit 0df8a27bbaf51b55c0e8c3a533ef4c2ff9d79c9f removed the system
> >> quota.h include, but in doing so, added the problem:
> >> mkquota.c:55:2: warning: implicit declaration of function 'quotactl'
> >> 
> >> Since we're maintaining a copy of quota.h, add a proper func prototype.
> >> 
> >> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> > 
> > Thanks, applied.
> 
> This patch caused a compile failure on my FC 13 system, when I had no
> problem before, because caddr_t was not defined...

your definition of "no problem" is different from mine.  Ted's latest patch 
works fine for me though -- punt the call completely.
-mike

Patch

diff --git a/lib/quota/quota.h b/lib/quota/quota.h
index a943ec6..3eaec1d 100644
--- a/lib/quota/quota.h
+++ b/lib/quota/quota.h
@@ -152,4 +152,9 @@  enum {
 };
 #define QUOTA_NL_A_MAX (__QUOTA_NL_A_MAX - 1)
 
+#ifdef HAVE_QUOTACTL
+extern int quotactl(int __cmd, const char *__special, int __id,
+		    caddr_t __addr);
+#endif
+
 #endif /* _QUOTA_ */