Patchwork rs6000.c missing target hook

login
register
mail settings
Submitter David Edelsohn
Date May 22, 2012, 2:15 p.m.
Message ID <CAGWvny=AONM=RbE2n7eMWoSk5keDy0wsz-U3wDSGswFzKMQPUw@mail.gmail.com>
Download mbox | patch
Permalink /patch/160647/
State New
Headers show

Comments

David Edelsohn - May 22, 2012, 2:15 p.m.
During one of the target hook conversions,
rs6000_aix_asm_output_dwarf_table_ref() retained a use of
TARGET_STRIP_NAME_ENCODING macro instead of the target hook, which
broke when Alan cleaned up rs6000.c.  Fixed thusly.

- David

* config/rs6000/rs6000.c (rs6000_aix_asm_output_dwarf_table_ref): Use
strip_name_encoding target hook.

 /* This ties together stack memory (MEM with an alias set of frame_alias_set)
Mike Stump - May 22, 2012, 5:31 p.m.
On May 22, 2012, at 7:15 AM, David Edelsohn wrote:
> * config/rs6000/rs6000.c (rs6000_aix_asm_output_dwarf_table_ref): Use
> strip_name_encoding target hook.
> 
> Index: rs6000.c
> ===================================================================
> --- rs6000.c    (revision 187756)
> +++ rs6000.c    (working copy)
> @@ -18392,7 +18392,7 @@
> rs6000_aix_asm_output_dwarf_table_ref (char * frame_table_label)
> {
>   fprintf (asm_out_file, "\t.ref %s\n",
> -          TARGET_STRIP_NAME_ENCODING (frame_table_label));
> +          (* targetm.strip_name_encoding) (frame_table_label));

Any reason to not remove (* and )?
David Edelsohn - May 22, 2012, 11:56 p.m.
On Tue, May 22, 2012 at 1:31 PM, Mike Stump <mikestump@comcast.net> wrote:

>>   fprintf (asm_out_file, "\t.ref %s\n",
>> -          TARGET_STRIP_NAME_ENCODING (frame_table_label));
>> +          (* targetm.strip_name_encoding) (frame_table_label));
>
> Any reason to not remove (* and )?

I wanted to be consistent with the rest of the file, which uses that style.

- David

Patch

Index: rs6000.c
===================================================================
--- rs6000.c    (revision 187756)
+++ rs6000.c    (working copy)
@@ -18392,7 +18392,7 @@ 
 rs6000_aix_asm_output_dwarf_table_ref (char * frame_table_label)
 {
   fprintf (asm_out_file, "\t.ref %s\n",
-          TARGET_STRIP_NAME_ENCODING (frame_table_label));
+          (* targetm.strip_name_encoding) (frame_table_label));
 }