Patchwork [PULL,1.1,0/2] SCSI patches for 1.1.0-rc3

login
register
mail settings
Submitter Paolo Bonzini
Date May 22, 2012, 12:25 p.m.
Message ID <1337689547-6338-1-git-send-email-pbonzini@redhat.com>
Download mbox
Permalink /patch/160625/
State New
Headers show

Pull-request

git://github.com/bonzini/qemu.git scsi-next

Comments

Paolo Bonzini - May 22, 2012, 12:25 p.m.
The following changes since commit 76ee152a86d5f2533443ce4d2be6fe253cfb3c45:

  Update version to 1.1.0-rc2 (2012-05-14 17:56:50 -0500)

are available in the git repository at:

  git://github.com/bonzini/qemu.git scsi-next

for you to fetch changes up to e1a2d34f4abd8a117f5c5a25a5bb2e67d597de23:

  ISCSI: call qemu_notify_event() after updating events (2012-05-22 14:14:05 +0200)

----------------------------------------------------------------
Jim Meyering (1):
      scsi: declare vmstate_info_scsi_requests to be static

Ronnie Sahlberg (1):
      ISCSI: call qemu_notify_event() after updating events

 block/iscsi.c |    7 +++++++
 hw/scsi-bus.c |    2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)
Paolo Bonzini - May 25, 2012, 11:11 a.m.
Il 22/05/2012 14:25, Paolo Bonzini ha scritto:
> The following changes since commit 76ee152a86d5f2533443ce4d2be6fe253cfb3c45:
> 
>   Update version to 1.1.0-rc2 (2012-05-14 17:56:50 -0500)
> 
> are available in the git repository at:
> 
>   git://github.com/bonzini/qemu.git scsi-next
> 
> for you to fetch changes up to e1a2d34f4abd8a117f5c5a25a5bb2e67d597de23:
> 
>   ISCSI: call qemu_notify_event() after updating events (2012-05-22 14:14:05 +0200)

Rebased, commit cd0b3cc9eee6f9b6b165f24787b4290bdc1c3f68 is now the tip
of the branch.

Paolo

> ----------------------------------------------------------------
> Jim Meyering (1):
>       scsi: declare vmstate_info_scsi_requests to be static
> 
> Ronnie Sahlberg (1):
>       ISCSI: call qemu_notify_event() after updating events
> 
>  block/iscsi.c |    7 +++++++
>  hw/scsi-bus.c |    2 +-
>  2 files changed, 8 insertions(+), 1 deletion(-)
ronniesahlberg@gmail.com - May 26, 2012, 5:41 a.m.
Paolo,

You need this patch too since without it it might crash.

commit 6e46eb1846a862dad253be1a576f8554071b154a
Author: Ronnie Sahlberg <ronniesahlberg@gmail.com>
Date:   Sat May 26 10:28:05 2012 +1000

    ISCSI: We can only do the shortcircuit and write directly to the socket
    IFF we know the socket is open (and writeable).
    If the target is more than insignificant distance away, we could otherwise
    try to write to the socket before the nonblocking connect has completed
    which would cause a crash.

    Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>


The other patches in the series can wait until later,  but this one is
needed for 1.1


regards
ronnie sahlberg



On Fri, May 25, 2012 at 9:11 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 22/05/2012 14:25, Paolo Bonzini ha scritto:
>> The following changes since commit 76ee152a86d5f2533443ce4d2be6fe253cfb3c45:
>>
>>   Update version to 1.1.0-rc2 (2012-05-14 17:56:50 -0500)
>>
>> are available in the git repository at:
>>
>>   git://github.com/bonzini/qemu.git scsi-next
>>
>> for you to fetch changes up to e1a2d34f4abd8a117f5c5a25a5bb2e67d597de23:
>>
>>   ISCSI: call qemu_notify_event() after updating events (2012-05-22 14:14:05 +0200)
>
> Rebased, commit cd0b3cc9eee6f9b6b165f24787b4290bdc1c3f68 is now the tip
> of the branch.
>
> Paolo
>
>> ----------------------------------------------------------------
>> Jim Meyering (1):
>>       scsi: declare vmstate_info_scsi_requests to be static
>>
>> Ronnie Sahlberg (1):
>>       ISCSI: call qemu_notify_event() after updating events
>>
>>  block/iscsi.c |    7 +++++++
>>  hw/scsi-bus.c |    2 +-
>>  2 files changed, 8 insertions(+), 1 deletion(-)
>
>
Paolo Bonzini - May 26, 2012, 7:46 a.m.
Il 26/05/2012 07:41, ronnie sahlberg ha scritto:
> Paolo,
> 
> You need this patch too since without it it might crash.
> 
> commit 6e46eb1846a862dad253be1a576f8554071b154a
> Author: Ronnie Sahlberg <ronniesahlberg@gmail.com>
> Date:   Sat May 26 10:28:05 2012 +1000
> 
>     ISCSI: We can only do the shortcircuit and write directly to the socket
>     IFF we know the socket is open (and writeable).
>     If the target is more than insignificant distance away, we could otherwise
>     try to write to the socket before the nonblocking connect has completed
>     which would cause a crash.
> 
>     Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
> 
> 
> The other patches in the series can wait until later,  but this one is
> needed for 1.1

I didn't get the patch, so I redid it.

Can you test asap git://github.com/bonzini/qemu.git, branch
scsi-candidate-1.1 to see if it matches what you want to be in 1.1?

Paolo
ronniesahlberg@gmail.com - May 26, 2012, 7:59 a.m.
Almost,
but connecter=1 should be set after the if statement not inside it.

     if (status != 0) {
+        itask->iscsilun->connected = 1;
         itask->status   = 1;

I.e. dont set it in the error path, set it after the block. then it
should be all good.



optionally you can revert 5b5e96bba6835b794ba237c1ddd6580dea8d4aef
and use the patch I attach instead


regards
ronnie sahlberg


 2012 at 5:46 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 26/05/2012 07:41, ronnie sahlberg ha scritto:
>> Paolo,
>>
>> You need this patch too since without it it might crash.
>>
>> commit 6e46eb1846a862dad253be1a576f8554071b154a
>> Author: Ronnie Sahlberg <ronniesahlberg@gmail.com>
>> Date:   Sat May 26 10:28:05 2012 +1000
>>
>>     ISCSI: We can only do the shortcircuit and write directly to the socket
>>     IFF we know the socket is open (and writeable).
>>     If the target is more than insignificant distance away, we could otherwise
>>     try to write to the socket before the nonblocking connect has completed
>>     which would cause a crash.
>>
>>     Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
>>
>>
>> The other patches in the series can wait until later,  but this one is
>> needed for 1.1
>
> I didn't get the patch, so I redid it.
>
> Can you test asap git://github.com/bonzini/qemu.git, branch
> scsi-candidate-1.1 to see if it matches what you want to be in 1.1?
>
> Paolo
ronniesahlberg@gmail.com - May 26, 2012, 8:17 a.m.
Im compiling your branch now and will verify all is good.

It is missing an include  so you need to add this patch to compile :




On Sat, May 26, 2012 at 5:59 PM, ronnie sahlberg
<ronniesahlberg@gmail.com> wrote:
> Almost,
> but connecter=1 should be set after the if statement not inside it.
>
>     if (status != 0) {
> +        itask->iscsilun->connected = 1;
>         itask->status   = 1;
>
> I.e. dont set it in the error path, set it after the block. then it
> should be all good.
>
>
>
> optionally you can revert 5b5e96bba6835b794ba237c1ddd6580dea8d4aef
> and use the patch I attach instead
>
>
> regards
> ronnie sahlberg
>
>
>  2012 at 5:46 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> Il 26/05/2012 07:41, ronnie sahlberg ha scritto:
>>> Paolo,
>>>
>>> You need this patch too since without it it might crash.
>>>
>>> commit 6e46eb1846a862dad253be1a576f8554071b154a
>>> Author: Ronnie Sahlberg <ronniesahlberg@gmail.com>
>>> Date:   Sat May 26 10:28:05 2012 +1000
>>>
>>>     ISCSI: We can only do the shortcircuit and write directly to the socket
>>>     IFF we know the socket is open (and writeable).
>>>     If the target is more than insignificant distance away, we could otherwise
>>>     try to write to the socket before the nonblocking connect has completed
>>>     which would cause a crash.
>>>
>>>     Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
>>>
>>>
>>> The other patches in the series can wait until later,  but this one is
>>> needed for 1.1
>>
>> I didn't get the patch, so I redid it.
>>
>> Can you test asap git://github.com/bonzini/qemu.git, branch
>> scsi-candidate-1.1 to see if it matches what you want to be in 1.1?
>>
>> Paolo
ronniesahlberg@gmail.com - May 26, 2012, 9:18 a.m.
I have compiled your branch and run through some tests.

It all looks good as long as you apply the patch to #include "hw/scsi-defs.h"



On Sat, May 26, 2012 at 6:17 PM, ronnie sahlberg
<ronniesahlberg@gmail.com> wrote:
> Im compiling your branch now and will verify all is good.
>
> It is missing an include  so you need to add this patch to compile :
>
>
>
>
> On Sat, May 26, 2012 at 5:59 PM, ronnie sahlberg
> <ronniesahlberg@gmail.com> wrote:
>> Almost,
>> but connecter=1 should be set after the if statement not inside it.
>>
>>     if (status != 0) {
>> +        itask->iscsilun->connected = 1;
>>         itask->status   = 1;
>>
>> I.e. dont set it in the error path, set it after the block. then it
>> should be all good.
>>
>>
>>
>> optionally you can revert 5b5e96bba6835b794ba237c1ddd6580dea8d4aef
>> and use the patch I attach instead
>>
>>
>> regards
>> ronnie sahlberg
>>
>>
>>  2012 at 5:46 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>> Il 26/05/2012 07:41, ronnie sahlberg ha scritto:
>>>> Paolo,
>>>>
>>>> You need this patch too since without it it might crash.
>>>>
>>>> commit 6e46eb1846a862dad253be1a576f8554071b154a
>>>> Author: Ronnie Sahlberg <ronniesahlberg@gmail.com>
>>>> Date:   Sat May 26 10:28:05 2012 +1000
>>>>
>>>>     ISCSI: We can only do the shortcircuit and write directly to the socket
>>>>     IFF we know the socket is open (and writeable).
>>>>     If the target is more than insignificant distance away, we could otherwise
>>>>     try to write to the socket before the nonblocking connect has completed
>>>>     which would cause a crash.
>>>>
>>>>     Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
>>>>
>>>>
>>>> The other patches in the series can wait until later,  but this one is
>>>> needed for 1.1
>>>
>>> I didn't get the patch, so I redid it.
>>>
>>> Can you test asap git://github.com/bonzini/qemu.git, branch
>>> scsi-candidate-1.1 to see if it matches what you want to be in 1.1?
>>>
>>> Paolo
Paolo Bonzini - May 28, 2012, 6:46 a.m.
Il 26/05/2012 11:18, ronnie sahlberg ha scritto:
> I have compiled your branch and run through some tests.
> 
> It all looks good as long as you apply the patch to #include "hw/scsi-defs.h"

Thanks, I updated the scsi-next branch.

Paolo
Anthony Liguori - May 29, 2012, 9:15 a.m.
On 05/28/2012 01:46 AM, Paolo Bonzini wrote:
> Il 26/05/2012 11:18, ronnie sahlberg ha scritto:
>> I have compiled your branch and run through some tests.
>>
>> It all looks good as long as you apply the patch to #include "hw/scsi-defs.h"
>
> Thanks, I updated the scsi-next branch.

So should I expect a new branch for this pull?

Regards,

Anthony Liguori

>
> Paolo
>
>
>
Paolo Bonzini - May 29, 2012, 9:20 a.m.
Il 29/05/2012 11:15, Anthony Liguori ha scritto:
>>>
>>>
>>> It all looks good as long as you apply the patch to #include
>>> "hw/scsi-defs.h"
>>
>> Thanks, I updated the scsi-next branch.
> 
> So should I expect a new branch for this pull?

No, same branch, one more patch.  I just sent the pull request again.

Paolo
Anthony Liguori - May 30, 2012, 1:28 a.m.
On 05/22/2012 07:25 AM, Paolo Bonzini wrote:
> The following changes since commit 76ee152a86d5f2533443ce4d2be6fe253cfb3c45:
>
>    Update version to 1.1.0-rc2 (2012-05-14 17:56:50 -0500)

Pulled.  Thanks.

Regards,

Anthony Liguori

>
> are available in the git repository at:
>
>    git://github.com/bonzini/qemu.git scsi-next
>
> for you to fetch changes up to e1a2d34f4abd8a117f5c5a25a5bb2e67d597de23:
>
>    ISCSI: call qemu_notify_event() after updating events (2012-05-22 14:14:05 +0200)
>
> ----------------------------------------------------------------
> Jim Meyering (1):
>        scsi: declare vmstate_info_scsi_requests to be static
>
> Ronnie Sahlberg (1):
>        ISCSI: call qemu_notify_event() after updating events
>
>   block/iscsi.c |    7 +++++++
>   hw/scsi-bus.c |    2 +-
>   2 files changed, 8 insertions(+), 1 deletion(-)