From patchwork Tue May 22 08:37:57 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olivia Yin X-Patchwork-Id: 160567 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 9763DB6F86 for ; Tue, 22 May 2012 18:54:48 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756507Ab2EVIyb (ORCPT ); Tue, 22 May 2012 04:54:31 -0400 Received: from tx2ehsobe005.messaging.microsoft.com ([65.55.88.15]:18098 "EHLO tx2outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756682Ab2EVIy0 (ORCPT ); Tue, 22 May 2012 04:54:26 -0400 Received: from mail176-tx2-R.bigfish.com (10.9.14.251) by TX2EHSOBE001.bigfish.com (10.9.40.21) with Microsoft SMTP Server id 14.1.225.23; Tue, 22 May 2012 08:54:12 +0000 Received: from mail176-tx2 (localhost [127.0.0.1]) by mail176-tx2-R.bigfish.com (Postfix) with ESMTP id 883392C082A; Tue, 22 May 2012 08:54:12 +0000 (UTC) X-SpamScore: 0 X-BigFish: VS0(zzzz1202hzz8275bhz2dh2a8h668h839hd24he5bhf0ah) X-Forefront-Antispam-Report: CIP:70.37.183.190; KIP:(null); UIP:(null); IPV:NLI; H:mail.freescale.net; RD:none; EFVD:NLI Received: from mail176-tx2 (localhost.localdomain [127.0.0.1]) by mail176-tx2 (MessageSwitch) id 1337676851219641_9658; Tue, 22 May 2012 08:54:11 +0000 (UTC) Received: from TX2EHSMHS029.bigfish.com (unknown [10.9.14.252]) by mail176-tx2.bigfish.com (Postfix) with ESMTP id 3103F440103; Tue, 22 May 2012 08:54:11 +0000 (UTC) Received: from mail.freescale.net (70.37.183.190) by TX2EHSMHS029.bigfish.com (10.9.99.129) with Microsoft SMTP Server (TLS) id 14.1.225.23; Tue, 22 May 2012 08:54:10 +0000 Received: from az84smr01.freescale.net (10.64.34.197) by 039-SN1MMR1-003.039d.mgd.msft.net (10.84.1.16) with Microsoft SMTP Server (TLS) id 14.2.298.5; Tue, 22 May 2012 03:54:24 -0500 Received: from localhost.localdomain (rock.ap.freescale.net [10.193.20.106]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id q4M8sFs3018831; Tue, 22 May 2012 01:54:21 -0700 From: Olivia Yin To: CC: , , Olivia Yin Subject: [PATCH] KVM:PPC:clean up in-kernel exit_timing statistics Date: Tue, 22 May 2012 16:37:57 +0800 Message-ID: <1337675877-2949-1-git-send-email-hong-hua.yin@freescale.com> X-Mailer: git-send-email 1.6.4 MIME-Version: 1.0 X-OriginatorOrg: freescale.com Sender: kvm-ppc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm-ppc@vger.kernel.org 1. Line up the columns with headings. 2. Add units for min/max/sum columns. 3. add_exit_timing only count the exited types. For other types, the min value should be zero, instead of the init value (0xFFFFFFFF). Signed-off-by: Olivia Yin --- arch/powerpc/kvm/timing.c | 13 +++++++++---- 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/kvm/timing.c b/arch/powerpc/kvm/timing.c index 07b6110..11a67db 100644 --- a/arch/powerpc/kvm/timing.c +++ b/arch/powerpc/kvm/timing.c @@ -144,13 +144,18 @@ static int kvmppc_exit_timing_show(struct seq_file *m, void *private) int i; u64 min, max, sum, sum_quad; - seq_printf(m, "%s", "type count min max sum sum_squared\n"); + seq_printf(m, "%s", "\ttype\t count\t min(ns)\t max(ns)\ + sum(ns)\t\t sum_squared\n"); for (i = 0; i < __NUMBER_OF_KVM_EXIT_TYPES; i++) { - min = vcpu->arch.timing_min_duration[i]; - do_div(min, tb_ticks_per_usec); + if (vcpu->arch.timing_count_type[i] != 0) { + min = vcpu->arch.timing_min_duration[i]; + do_div(min, tb_ticks_per_usec); + } else { + min = 0; + } max = vcpu->arch.timing_max_duration[i]; do_div(max, tb_ticks_per_usec); sum = vcpu->arch.timing_sum_duration[i]; @@ -158,7 +163,7 @@ static int kvmppc_exit_timing_show(struct seq_file *m, void *private) sum_quad = vcpu->arch.timing_sum_quad_duration[i]; do_div(sum_quad, tb_ticks_per_usec); - seq_printf(m, "%12s %10d %10lld %10lld %20lld %20lld\n", + seq_printf(m, "%12s %10d %10lld %10lld %15lld %20lld\n", kvm_exit_names[i], vcpu->arch.timing_count_type[i], min,