diff mbox

[U-Boot] Fix cmd_nvedit.c: warning: unused variable 'bd'

Message ID 1337584427-2519-1-git-send-email-wd@denx.de
State Superseded
Delegated to: Wolfgang Denk
Headers show

Commit Message

Wolfgang Denk May 21, 2012, 7:13 a.m. UTC
Commit 50a47d0 "net: punt bd->bi_ip_addr" introduced a build warning.
Fix it.

Signed-off-by: Wolfgang Denk <wd@denx.de>
Cc: Mike Frysinger <vapier@gentoo.org>
---
 common/cmd_nvedit.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Comments

Joe Hershberger May 21, 2012, 8:49 p.m. UTC | #1
On Mon, May 21, 2012 at 2:13 AM, Wolfgang Denk <wd@denx.de> wrote:
> Commit 50a47d0 "net: punt bd->bi_ip_addr" introduced a build warning.
> Fix it.
>
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Mike Frysinger <vapier@gentoo.org>

Applied, thanks.

-Joe
Wolfgang Denk May 21, 2012, 9:55 p.m. UTC | #2
Dear Joe Hershberger,

In message <CANr=Z=bVYVDM_qoUngpEUz0x4S1P4bZYPbypU_P2grzvARnKXQ@mail.gmail.com> you wrote:
> On Mon, May 21, 2012 at 2:13 AM, Wolfgang Denk <wd@denx.de> wrote:
> > Commit 50a47d0 "net: punt bd->bi_ip_addr" introduced a build warning.
> > Fix it.
> >
> > Signed-off-by: Wolfgang Denk <wd@denx.de>
> > Cc: Mike Frysinger <vapier@gentoo.org>
> 
> Applied, thanks.

Umm... how comes?

This falls not into your bailiwick...

Best regards,

Wolfgang Denk
Joe Hershberger May 21, 2012, 9:56 p.m. UTC | #3
On Mon, May 21, 2012 at 4:55 PM, Wolfgang Denk <wd@denx.de> wrote:
> Dear Joe Hershberger,
>
> In message <CANr=Z=bVYVDM_qoUngpEUz0x4S1P4bZYPbypU_P2grzvARnKXQ@mail.gmail.com> you wrote:
>> On Mon, May 21, 2012 at 2:13 AM, Wolfgang Denk <wd@denx.de> wrote:
>> > Commit 50a47d0 "net: punt bd->bi_ip_addr" introduced a build warning.
>> > Fix it.
>> >
>> > Signed-off-by: Wolfgang Denk <wd@denx.de>
>> > Cc: Mike Frysinger <vapier@gentoo.org>
>>
>> Applied, thanks.
>
> Umm... how comes?
>
> This falls not into your bailiwick...

Only because the break came through me.

-Joe
Wolfgang Denk May 21, 2012, 10:01 p.m. UTC | #4
Dear Joe Hershberger,

In message <CANr=Z=aDCq+E2yeDpPXLxtoRyN3G3tOs7v0h=q4_of_ybkH8Hw@mail.gmail.com> you wrote:
> On Mon, May 21, 2012 at 4:55 PM, Wolfgang Denk <wd@denx.de> wrote:
> > Dear Joe Hershberger,
> >
> > In message <CANr=Z=bVYVDM_qoUngpEUz0x4S1P4bZYPbypU_P2grzvARnKXQ@mail.gmail.com> you wrote:
> >> On Mon, May 21, 2012 at 2:13 AM, Wolfgang Denk <wd@denx.de> wrote:
> >> > Commit 50a47d0 "net: punt bd->bi_ip_addr" introduced a build warning.
> >> > Fix it.
> >> >
> >> > Signed-off-by: Wolfgang Denk <wd@denx.de>
> >> > Cc: Mike Frysinger <vapier@gentoo.org>
> >>
> >> Applied, thanks.
> >
> > Umm... how comes?
> >
> > This falls not into your bailiwick...
> 
> Only because the break came through me.

This is a common file that is unrelated with network code.  It shuld
not go through the net repo.  [If you want to go ahead, you can pull
it into the stagiung repo, and send a pull reqest fot that - but for a
single patch that makes little sense.]

Best regards,

Wolfgang Denk
Joe Hershberger May 21, 2012, 10:02 p.m. UTC | #5
Hi Wolfgang,

On Mon, May 21, 2012 at 5:01 PM, Wolfgang Denk <wd@denx.de> wrote:
> Dear Joe Hershberger,
>
> In message <CANr=Z=aDCq+E2yeDpPXLxtoRyN3G3tOs7v0h=q4_of_ybkH8Hw@mail.gmail.com> you wrote:
>> On Mon, May 21, 2012 at 4:55 PM, Wolfgang Denk <wd@denx.de> wrote:
>> > Dear Joe Hershberger,
>> >
>> > In message <CANr=Z=bVYVDM_qoUngpEUz0x4S1P4bZYPbypU_P2grzvARnKXQ@mail.gmail.com> you wrote:
>> >> On Mon, May 21, 2012 at 2:13 AM, Wolfgang Denk <wd@denx.de> wrote:
>> >> > Commit 50a47d0 "net: punt bd->bi_ip_addr" introduced a build warning.
>> >> > Fix it.
>> >> >
>> >> > Signed-off-by: Wolfgang Denk <wd@denx.de>
>> >> > Cc: Mike Frysinger <vapier@gentoo.org>
>> >>
>> >> Applied, thanks.
>> >
>> > Umm... how comes?
>> >
>> > This falls not into your bailiwick...
>>
>> Only because the break came through me.
>
> This is a common file that is unrelated with network code.  It shuld
> not go through the net repo.  [If you want to go ahead, you can pull
> it into the stagiung repo, and send a pull reqest fot that - but for a
> single patch that makes little sense.]

Sounds good... I'll drop it.  You can apply it directly.

Thanks,
-Joe
diff mbox

Patch

diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c
index 5999cb8..2712002 100644
--- a/common/cmd_nvedit.c
+++ b/common/cmd_nvedit.c
@@ -204,7 +204,6 @@  static int do_env_grep(cmd_tbl_t *cmdtp, int flag,
  */
 int _do_env_set(int flag, int argc, char * const argv[])
 {
-	bd_t  *bd = gd->bd;
 	int   i, len;
 	int   console = -1;
 	char  *name, *value, *s;