Patchwork ARM: mxs: Let GPMI driver be built by default

login
register
mail settings
Submitter Fabio Estevam
Date May 21, 2012, 3:20 a.m.
Message ID <1337570413-31407-1-git-send-email-festevam@gmail.com>
Download mbox | patch
Permalink /patch/160309/
State New
Headers show

Comments

Fabio Estevam - May 21, 2012, 3:20 a.m.
From: Fabio Estevam <fabio.estevam@freescale.com>

Let GPMI driver be built by default.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/configs/mxs_defconfig |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Shawn Guo - May 21, 2012, 4:19 a.m.
On Mon, May 21, 2012 at 12:20:13AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Let GPMI driver be built by default.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Queued for 3.6.  Thanks.

Regards,
Shawn

> ---
>  arch/arm/configs/mxs_defconfig |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/configs/mxs_defconfig b/arch/arm/configs/mxs_defconfig
> index 5406c23..6b86df7 100644
> --- a/arch/arm/configs/mxs_defconfig
> +++ b/arch/arm/configs/mxs_defconfig
> @@ -58,6 +58,9 @@ CONFIG_CAN_FLEXCAN=m
>  CONFIG_DEVTMPFS=y
>  # CONFIG_FIRMWARE_IN_KERNEL is not set
>  # CONFIG_BLK_DEV is not set
> +CONFIG_MTD=y
> +CONFIG_MTD_NAND=y
> +CONFIG_MTD_NAND_GPMI_NAND=y
>  CONFIG_NETDEVICES=y
>  CONFIG_NET_ETHERNET=y
>  CONFIG_ENC28J60=y
> -- 
> 1.7.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Marek Vasut - May 21, 2012, 4:48 a.m.
Dear Shawn Guo,

> On Mon, May 21, 2012 at 12:20:13AM -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam@freescale.com>
> > 
> > Let GPMI driver be built by default.
> > 
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Queued for 3.6.  Thanks.

Heh, if we get such trivial things in so late, the imx28 will be dead platform 
by the time it's supported mainline :-)

> 
> Regards,
> Shawn
> 
> > ---
> > 
> >  arch/arm/configs/mxs_defconfig |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/configs/mxs_defconfig
> > b/arch/arm/configs/mxs_defconfig index 5406c23..6b86df7 100644
> > --- a/arch/arm/configs/mxs_defconfig
> > +++ b/arch/arm/configs/mxs_defconfig
> > @@ -58,6 +58,9 @@ CONFIG_CAN_FLEXCAN=m
> > 
> >  CONFIG_DEVTMPFS=y
> >  # CONFIG_FIRMWARE_IN_KERNEL is not set
> >  # CONFIG_BLK_DEV is not set
> > 
> > +CONFIG_MTD=y
> > +CONFIG_MTD_NAND=y
> > +CONFIG_MTD_NAND_GPMI_NAND=y
> > 
> >  CONFIG_NETDEVICES=y
> >  CONFIG_NET_ETHERNET=y
> >  CONFIG_ENC28J60=y

Best regards,
Marek Vasut
Shawn Guo - May 21, 2012, 5:37 a.m.
On 21 May 2012 12:48, Marek Vasut <marex@denx.de> wrote:
> Heh, if we get such trivial things in so late, the imx28 will be dead platform
> by the time it's supported mainline :-)
>
It's late for v3.5 merge window.

Regards,
Shawn
Marek Vasut - May 21, 2012, 5:39 a.m.
Dear Shawn Guo,

> On 21 May 2012 12:48, Marek Vasut <marex@denx.de> wrote:
> > Heh, if we get such trivial things in so late, the imx28 will be dead
> > platform by the time it's supported mainline :-)
> 
> It's late for v3.5 merge window.

Well back in -around .30- it was still ok to add minor stuffs even if it was 
around rc1, they didn't break anything afterall. And this doesn't break anything 
(well, the gpmi driver is broken, so fix it ... if you get more people to use 
it, you'll have the fixes pouring your direction ... isn't that your objective, 
to make linux kernel even better than it is?)

> Regards,
> Shawn

Best regards,
Marek Vasut
Shawn Guo - May 21, 2012, 5:48 a.m.
On Mon, May 21, 2012 at 07:39:46AM +0200, Marek Vasut wrote:
> Dear Shawn Guo,
> 
> > On 21 May 2012 12:48, Marek Vasut <marex@denx.de> wrote:
> > > Heh, if we get such trivial things in so late, the imx28 will be dead
> > > platform by the time it's supported mainline :-)
> > 
> > It's late for v3.5 merge window.
> 
> Well back in -around .30- it was still ok to add minor stuffs even if it was 
> around rc1, they didn't break anything afterall. And this doesn't break anything 
> (well, the gpmi driver is broken, so fix it ... if you get more people to use 
> it, you'll have the fixes pouring your direction ... isn't that your objective, 
> to make linux kernel even better than it is?)
> 
The -rc should mostly be for bugfix.  I also hope we can enable the
driver in defconfig as soon as possible, but I won't do it until the
driver is actually working with all known bugs fixed.
Marek Vasut - May 21, 2012, 6:22 a.m.
Dear Shawn Guo,

> On Mon, May 21, 2012 at 07:39:46AM +0200, Marek Vasut wrote:
> > Dear Shawn Guo,
> > 
> > > On 21 May 2012 12:48, Marek Vasut <marex@denx.de> wrote:
> > > > Heh, if we get such trivial things in so late, the imx28 will be dead
> > > > platform by the time it's supported mainline :-)
> > > 
> > > It's late for v3.5 merge window.
> > 
> > Well back in -around .30- it was still ok to add minor stuffs even if it
> > was around rc1, they didn't break anything afterall. And this doesn't
> > break anything (well, the gpmi driver is broken, so fix it ... if you
> > get more people to use it, you'll have the fixes pouring your direction
> > ... isn't that your objective, to make linux kernel even better than it
> > is?)
> 
> The -rc should mostly be for bugfix.  I also hope we can enable the
> driver in defconfig as soon as possible, but I won't do it until the
> driver is actually working with all known bugs fixed.

You've chosen the wrong approach then. There's always one remaining bug. But the 
more eyes on the code, the faster the bugs will be fixed.

Best regards,
Marek Vasut
Shawn Guo - May 21, 2012, 6:26 a.m.
On 21 May 2012 14:22, Marek Vasut <marex@denx.de> wrote:
> You've chosen the wrong approach then. There's always one remaining bug. But the
> more eyes on the code, the faster the bugs will be fixed.
>
There's always one remaining bug which is to be found, not the bugs
that we have known.

Anyway, as I've said it's not a bug fix.  Thus it's not a candidate
for v3.5-rc.  It's simple as it is.

Regards,
Shawn

Patch

diff --git a/arch/arm/configs/mxs_defconfig b/arch/arm/configs/mxs_defconfig
index 5406c23..6b86df7 100644
--- a/arch/arm/configs/mxs_defconfig
+++ b/arch/arm/configs/mxs_defconfig
@@ -58,6 +58,9 @@  CONFIG_CAN_FLEXCAN=m
 CONFIG_DEVTMPFS=y
 # CONFIG_FIRMWARE_IN_KERNEL is not set
 # CONFIG_BLK_DEV is not set
+CONFIG_MTD=y
+CONFIG_MTD_NAND=y
+CONFIG_MTD_NAND_GPMI_NAND=y
 CONFIG_NETDEVICES=y
 CONFIG_NET_ETHERNET=y
 CONFIG_ENC28J60=y